Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added author-award table for venues (closes #713) #848

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

mkutmon
Copy link
Collaborator

@mkutmon mkutmon commented Oct 8, 2019

No description provided.

@fnielsen
Copy link
Collaborator

I am wondering if we could make it a bit more informative by count, date or description?

@fnielsen
Copy link
Collaborator

I think we also need a LIMIT since, e.g., Q180445 (Nature) times out.

@fnielsen fnielsen merged commit 7db7455 into WDscholia:master Oct 14, 2019
@fnielsen
Copy link
Collaborator

Now running, e.g., https://tools.wmflabs.org/scholia/venue/Q6294930

Copy link
Collaborator

@fnielsen fnielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@@ -352,5 +361,9 @@ <h3>Authorships</h3>
<table class="table table-hover" id="authorships-gender-distribution"></table>


<h2 id="AuthorAwards">Author Awards</h2>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering whether there should be a space in "AuthorAwards"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just the id of the header, right? The text itself has a space.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. On the other hand, I do not know if it is a good idea to have spaces in the ids (as I have been doing in the past). Do you know if one can run into problems with that? Maybe it is better with a dash?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay. I never used spaces in ids.
Just found this for example: "HTML 5 is even more permissive, saying only that an id must contain at least one character and may not contain any space characters."

So I guess it's better to remove spaces. It doesn't really matter if it's author-awards or AuthorAwards or authorAwards but I would try to stick to one naming convention.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the lookup. Maybe we should convert the spaces to a dash and lowercase when the word is not the first, e.g., "Author-awards". I hope that does not collide with the table-id.

?item wdt:P1433 wd:{{ q }} ;
wdt:P50 ?author .
?author wdt:P166 ?award .
SERVICE wikibase:label { bd:serviceParam wikibase:language "[AUTO_LANGUAGE],en". }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extended this with some more languages. Maybe the service labeling should be parametrized.

@mkutmon
Copy link
Collaborator Author

mkutmon commented Oct 15, 2019

I am wondering if we could make it a bit more informative by count, date or description?

I'll check when I have time. We should be able to group the information nicely.

@fnielsen
Copy link
Collaborator

I have already added the information.

@fnielsen fnielsen added aspects the way Scholia looks at Wikidata data enhancement some suggestions to improve Scholia labels Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspects the way Scholia looks at Wikidata data enhancement some suggestions to improve Scholia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants