-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added author-award table for venues (closes #713) #848
added author-award table for venues (closes #713) #848
Conversation
I am wondering if we could make it a bit more informative by count, date or description? |
I think we also need a LIMIT since, e.g., Q180445 (Nature) times out. |
Now running, e.g., https://tools.wmflabs.org/scholia/venue/Q6294930 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
@@ -352,5 +361,9 @@ <h3>Authorships</h3> | |||
<table class="table table-hover" id="authorships-gender-distribution"></table> | |||
|
|||
|
|||
<h2 id="AuthorAwards">Author Awards</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering whether there should be a space in "AuthorAwards"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just the id of the header, right? The text itself has a space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. On the other hand, I do not know if it is a good idea to have spaces in the ids (as I have been doing in the past). Do you know if one can run into problems with that? Maybe it is better with a dash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay. I never used spaces in ids.
Just found this for example: "HTML 5 is even more permissive, saying only that an id must contain at least one character and may not contain any space characters."
So I guess it's better to remove spaces. It doesn't really matter if it's author-awards or AuthorAwards or authorAwards but I would try to stick to one naming convention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the lookup. Maybe we should convert the spaces to a dash and lowercase when the word is not the first, e.g., "Author-awards". I hope that does not collide with the table-id.
?item wdt:P1433 wd:{{ q }} ; | ||
wdt:P50 ?author . | ||
?author wdt:P166 ?award . | ||
SERVICE wikibase:label { bd:serviceParam wikibase:language "[AUTO_LANGUAGE],en". } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I extended this with some more languages. Maybe the service labeling should be parametrized.
I'll check when I have time. We should be able to group the information nicely. |
I have already added the information. |
No description provided.