Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate documentation and add link to readme (#1479) #1486

Closed
wants to merge 2 commits into from

Conversation

carlinmack
Copy link
Collaborator

@carlinmack carlinmack commented Jul 7, 2021

For #1479

This PR introduces DOCUMENTATION.md which is generated by pdoc. This lists all the docstrings in one place, allowing people to easily search for the modules and methods that may be of use to them. There are two caveats:

  • Unfortunately the generator that was used (pdoc) only outputs in markdown, HTML and PDF. As such, DOCUMENTATION.md will be the only markdown file in this repository.
  • pdoc does not correctly handle the from .x import y import format. As such, two modules — qs and tex — must be adjusted so that the documentation can be generated. Therefore these should be tested in the environments they are used, to ensure that these are not breaking changes.

If either of these are deal breakers, I'll look into other generators.

With the addition of a config file, hyperlinking can be added to the module names (example) which is helpful for UX, but I didn't want to introduce this file to the repository.

This documentation is for all but two modules (qs and tex). pdoc fails
to render these as they use the `from .module import x` format
which I am unfamiliar with.

The command to generated DOCUMENTATION.md was:

`pdoc api arxiv github googlescholar model network query rss text utils
 wikipedia > ../DOCUMENTATION.md`
Unfortunately these files must be slightly modified for the generation.
As such, these files should be tested in the environments they are used
to ensure that these are not breaking changes.
@carlinmack carlinmack marked this pull request as draft July 8, 2021 11:56
@Daniel-Mietchen
Copy link
Member

I had a first look and liked what I saw. We should probably couple this to official release workflows too, as per #495 and #847.

@carlinmack
Copy link
Collaborator Author

closing in favour of #1557

@carlinmack carlinmack closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants