Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subdirectories are not installed with pip #1630

Closed
fnielsen opened this issue Aug 27, 2021 · 1 comment
Closed

Subdirectories are not installed with pip #1630

fnielsen opened this issue Aug 27, 2021 · 1 comment
Assignees
@fnielsen
Labels
bug something wrong on our end

Comments

@fnielsen
Copy link
Collaborator 

$ python3 -m pip install git+https://[email protected]/cthoyt/scholia.git@simplify-launch
$ scholia 
Usage:
 ...
$ scholia run
Traceback (most recent call last):
  File "/home/<user>/venvs/scholia/bin/scholia", line 8, in <module>
    sys.exit(main())
  File "/home/<user>/venvs/scholia/lib/python3.8/site-packages/scholia/__main__.py", line 65, in main
    from .app import create_app
ModuleNotFoundError: No module named 'scholia.app'

Probably a problem with missing packages=find_packages() in `setup.py.
@fnielsen fnielsen self-assigned this Aug 27, 2021
@fnielsen fnielsen added the bug something wrong on our end label Aug 27, 2021
@fnielsen
Copy link
Collaborator Author

This bug shows up when trying the PR #1471

fnielsen added a commit that referenced this issue Aug 27, 2021
@fnielsen
Fix #1630 subdirectories not installed
404cf1a 
During pip install the subdirectories are not mentioned for
setup.py. find_packages from setuptools now specifies them.
This problem appears for #1471 when install scholia with pip.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnielsen fnielsen

Labels
bug something wrong on our end
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fnielsen