Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brazilian Portuguese (pt-BR) translation #45

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Add Brazilian Portuguese (pt-BR) translation #45

merged 2 commits into from
Dec 19, 2022

Conversation

wehagy
Copy link
Contributor

@wehagy wehagy commented Dec 19, 2022

Thank you for contributing to ProtonPlus! So that your Pull Request can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category

One of: Bugfix / Feature / Code style update / Refactoring Only / Build related changes / Documentation / Other (Please specify!)

Translation

Overview

Briefly outline your new changes...

Add Brazilian Portuguese (pt-BR) translation to ProtonPlus, waiting merge of branch 37-bugcritical-error-the-application-crashes-during-startup to test and request review.

Issue Number (if applicable)

Related issue: #00

New Vars (if applicable)

If you've added any new build scripts, environmental variables, config file options, dependency please outline here.

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot.

@Vysp3r
Copy link
Owner

Vysp3r commented Dec 19, 2022

I will make sure to add it in the next update. Thank you!

@Vysp3r Vysp3r marked this pull request as ready for review December 19, 2022 21:44
@Vysp3r Vysp3r changed the base branch from main to dev December 19, 2022 21:52
@Vysp3r Vysp3r merged commit 6a4efe2 into Vysp3r:dev Dec 19, 2022
@wehagy
Copy link
Contributor Author

wehagy commented Dec 19, 2022

Oh, I have thought to make tests right after the 37-bugcritical-error-the-application-crashes-during-startup is merged, anyway I have tested with version v0.3.1 patched, on clean fedora 37 vm, and with my system fedora 37 with launch option flatpak run --env=LANG=pt_BR.UTF-8 com.vysp3r.ProtonPlus, and works fine.

@Vysp3r
Copy link
Owner

Vysp3r commented Dec 19, 2022

I cannot merge that since it's not working for one user. By the way thanks for the tip, I didn't know you could run an app like that (using the env argument I mean). It will save me time :)

@wehagy wehagy deleted the brazilian-portuguese-not-spanish branch December 20, 2022 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants