Allow comments after Bundle declarations

[0]

As far as I can tell (as explained by :help command-bar), the only downside to this is:

A "|" inside the command argument is not allowed then.

which shouldn't pose any problems.

[0]

Fixes issue #13.

[gmarik]

@0 take a look into #50
Commit's were reverted for now...
We need to update documentation to reflect that double quotes aren't allowed anymore aswell...

[0]

Sorry about breaking it; should have tested more before pushing. Looks like I misunderstood the

Also checks for a " to start a comment.

part. It doesn't just check if a " starts a comment; it assumes " always starts a comment. As best as I can tell, the options are: disallow inline comments, but allow double quotes; or allow inline comments, but only use single quotes.

[gmarik]

That's ok. Bugs happen.)
But we definitely need to decide on which quote to use.
Personally i'd go with single quote.
But it'll be a pain to users, as #50 has showed...
We probably need to come up with migration/deprecation or smth like that...

[0]

Any ideas other than putting a line in the README stating the deprecation period and instructions to only use single quotes going forward? I don't know if it's at all possible to warn about double-quote usage.

[gmarik]

I was thinking about

• bumping Vundle's version (to 1.0 i guess) .
• making ppl aware that double quotes no longer supported(documentation/reddit/blog/etc)

The tricky part is that vundle auto-updates itself which means that it will definitely break for those using double-quotes. So before we fully migrate to single quotes we need to come up with (as you said) a warning letting ppl know that they should update config.
Or maybe just try/catch the double quote error and show warning that they should update config...
Not sure yet, need to come up with a good solution.

[greduan]

@gmarik @0 Just because this is still a topic that needs solving.

I think if we could implement some simple regex this would work. All we gotta do is check for one string, either single or double quotes, and then ignore anything after that. I don't think that should be too hard, unless you can't use regex in VimL.

[weynhamz]

Related to #13.

[MikeSpaceG]

Consistent behavior with the rest of Vim would be the correct answer. A " is a comment character.

[starcraftman]

This appears closed, I'll just note that it is supported with merge of #403.