Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme updates #409

Closed
wants to merge 2 commits into from
Closed

Readme updates #409

wants to merge 2 commits into from

Conversation

ches
Copy link

@ches ches commented Mar 22, 2014

Just some quick updates while I was looking at it.

ches added 2 commits March 23, 2014 02:00
Locking these to a specific treeish will keep them stable. The links
will have to be updated to refer to current docs as they are updated,
but at least clicking a link won't point you to something that may not
pertain at all to what you were expecting. Plus it was obviously already
necessary to maintain updated links one way or another...
@starcraftman
Copy link
Contributor

@ches Hi, thanks for pointing out these readme issues. I've already taken care of the line numbers with my merging of #403. Do you want to rebase to this master and I'll pull the help link change.

@ches
Copy link
Author

ches commented Mar 23, 2014

I still feel it would be preferable to base the doc links on a specific tree-ish so they're always highlighting the proper section (see the extended commit message: they may end up linking to stale documentation, but the alternative -- the current use of master -- means they sometimes end up showing something entirely different from what you expected when clicking). It's subject to debate, but to me the disorientation is more annoying than docs that most likely won't be drastically out-of-date if updating the links is forgotten for awhile.

Maybe the whole issue of maintaining the links in this fashion is a yak shave 😄

Happy to rebase, but the call for help change is completely trivial. If you'd like to keep the locking to tree-ish approach then I'll keep that and update as appropriate when rebasing.

@starcraftman
Copy link
Contributor

@ches Ah, I see what you mean. You want to prevent the use case where somebody updates the docs and the highlighting shifts. I agree that's really annoying. Wish github just had some anchoring in the files for the highlighting api so I could joint point at the titles. I'm gonna think on this a bit, not sure I want to hard code a commit.

@ches
Copy link
Author

ches commented Mar 24, 2014

Using the tag of latest release would be a reasonable compromise in ecosystems where people install packages from a versioned artifact repository, but alas, in Vim-land we all run everything from trunk, since the tools haven't yet coalesced to the ideal blend of the plugin managers and vim.org scripts archive... 😩

@lucc
Copy link
Contributor

lucc commented Apr 27, 2014

I think the best way would be to link to a release tag: https://github.com/gmarik/Vundle.vim/blob/v0.10/doc/vundle.txt#L100-200. Because the branch you might link to could also change. And the docs should only change on releases when the public api changes.

@jdevera
Copy link
Contributor

jdevera commented Apr 29, 2014

Using now the tag for the current version, as suggested by @lucc Thanks 👏

@jdevera jdevera closed this Apr 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants