Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handleOpen is stopping clicks on other components in the input slot #973

Closed
JohnCampionJr opened this issue Aug 21, 2024 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@JohnCampionJr
Copy link
Contributor

So I have an input control with a checkbox set as the input component in the slot.

image

But VueDatePicker stops the checkbox from working. (ie it works when the component is not inside of VueDatePicker).

I'm fairly sure this is being caused by the handleOpen click event preventing the default:

https://github.com/Vuepic/vue-datepicker/blob/6993cd913c95a504fd4c0079d86de54961566309/src/VueDatePicker/components/DatepickerInput.vue#L2C5-L2C30

which then goes here:

Could you add an ability to disable this event entirely?

@JohnCampionJr JohnCampionJr added awaiting triage The issue is not reviewed by the maintainers bug Something isn't working labels Aug 21, 2024
@JohnCampionJr
Copy link
Contributor Author

I have confirmed this in my fork and will provide a PR with my suggested fix :)

JohnCampionJr added a commit to JohnCampionJr/vue-datepicker that referenced this issue Aug 21, 2024
fix: root-click not needed with input slot (fixes Vuepic#973)
Jasenkoo added a commit that referenced this issue Sep 3, 2024
fix: root-click not needed with input slot (fixes #973)
@Jasenkoo Jasenkoo removed the awaiting triage The issue is not reviewed by the maintainers label Sep 3, 2024
@Jasenkoo Jasenkoo reopened this Sep 3, 2024
@Jasenkoo Jasenkoo closed this as completed Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants