-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make -q :: faster by calculating interactions on the fly instead of pre calculating them #2807
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a thought, should we test combining -q ::
with explicit -q AB
and other interactions --interaction AAA --interaction :::
?
Good idea about a mixed quadratics test, will add |
Relevant #1527 |
We will need to update these docs (see bottom) https://github.com/VowpalWabbit/vowpal_wabbit/wiki/Feature-interactions |
Awesome thanks, I would not have noticed that Added more tests to this, leaving it broken for now (tests timeout needs to be increased) since I am experiencing something strange for the latest tests: |
Looks good. |
This PR affects only
-q ::
for now, could be extended to also work for--cubic ::
in different PR.We don't hold all possible interactions anymore but calculate them on the fly by keeping namespaces when they are found.
This should not affect explicit quadratics when passed
Could potentially improve more. Reduces run time for a
ccb adf
run with a file with347k
examples and 3 interactions (Action,Slot,User) from ~11m41s
to ~1m50s