Cleanups in featurization #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ataymano
commented
Nov 16, 2023
ataymano
commented
- ":=" -> "=" for vw formatting
- moving context and action extraction back to featurizer
olgavrou
reviewed
Nov 16, 2023
src/learn_to_pick/pick_best.py
Outdated
| @@ -157,11 +140,29 @@ def _generic_namespaces(context, actions): | |||
| for a in actions: | |||
| a["#"] = PickBestFeaturizer._generic_namespace(a) | |||
|
|
|||
| def get_context_actions( | |||
There was a problem hiding this comment.
nit
Suggested change
| def get_context_actions( | |
| def get_context_and_actions( |
olgavrou
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.