Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting with ruff - the PR that nobody asked for! #503

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Linting with ruff - the PR that nobody asked for! #503

wants to merge 12 commits into from

Conversation

SebastianoF
Copy link

CHANGELOG

  • Invasive, possibly annoying, or possibly useful PR that delegates all stuff related to linting to ruff

PROS

  • one linter to rule them all
  • way faster to run the pre-commit hook
  • easy to move forward maintaining the code
  • a bug fixed in a jupyter notebook calling pd and never importing it
  • a few code smell removed

CONS

  • That's a loooooong PR to review

TESTS

  • no test added or changed. The only change is the code formatting

COMMENTS

  • Please note that I do not have an API key, so I could run only the tests that do not need one. In case the CI/CD does not re run those tests please run the tests with the key manually before productionisation!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SebastianoF