You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've done some digging and my observations are consistent with all agreed upon nonces per chain being reset to 0, while the individual reports of validators have not been reset. I think this line here is the culprit: https://github.com/palomachain/paloma/blob/master/x/skyway/keeper/keeper.go#L113 as it modifies the underlying transaction during iteration, which smells like the iterator would become invalid or unpredictable.
Instead of deleting the key, we can just reset it to 0 as well I think, OR we could delete all keys on record for this store. Either should work.
The text was updated successfully, but these errors were encountered:
# Related Github tickets
- VolumeFi#2061
# Background
- Fixes the Skyway nonce reset implementation during a compass ugprade
- Introduces a governance proposal message which may be used to override
the last nonce across all validators for a given chain to recover from a
desync
# Testing completed
- [x] test coverage exists or has been added/updated
- [x] tested in a private testnet
# Breaking changes
- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.
I've done some digging and my observations are consistent with all agreed upon nonces per chain being reset to 0, while the individual reports of validators have not been reset. I think this line here is the culprit: https://github.com/palomachain/paloma/blob/master/x/skyway/keeper/keeper.go#L113 as it modifies the underlying transaction during iteration, which smells like the iterator would become invalid or unpredictable.
Instead of deleting the key, we can just reset it to 0 as well I think, OR we could delete all keys on record for this store. Either should work.
The text was updated successfully, but these errors were encountered: