Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Skyway nonce is not reset #2061

Closed
verabehr opened this issue Aug 26, 2024 · 0 comments
Closed

[BUG] Skyway nonce is not reset #2061

verabehr opened this issue Aug 26, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@verabehr
Copy link

verabehr commented Aug 26, 2024

I've done some digging and my observations are consistent with all agreed upon nonces per chain being reset to 0, while the individual reports of validators have not been reset. I think this line here is the culprit: https://github.com/palomachain/paloma/blob/master/x/skyway/keeper/keeper.go#L113 as it modifies the underlying transaction during iteration, which smells like the iterator would become invalid or unpredictable.

Instead of deleting the key, we can just reset it to 0 as well I think, OR we could delete all keys on record for this store. Either should work.

@verabehr verabehr added the bug Something isn't working label Aug 26, 2024
@byte-bandit byte-bandit mentioned this issue Aug 27, 2024
4 tasks
taariq pushed a commit to palomachain/paloma that referenced this issue Aug 27, 2024
# Related Github tickets

- VolumeFi#2061

# Background

- Fixes the Skyway nonce reset implementation during a compass ugprade
- Introduces a governance proposal message which may be used to override
the last nonce across all validators for a given chain to recover from a
desync

# Testing completed

- [x] test coverage exists or has been added/updated
- [x] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.
@byte-bandit byte-bandit added this to the v2.1.1 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants