Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hardening] Assure batch_update_compass cannot be sent other than by vote #2043

Closed
byte-bandit opened this issue Aug 22, 2024 · 0 comments
Closed
Assignees
Milestone

Comments

@byte-bandit
Copy link

byte-bandit commented Aug 22, 2024

Since the batch_update_compass message is treated like very other message going to compass, the current architecture in Paloma would allow a hostile network takeover by an attacker modifying the Paloma code base to inject an EVM message with the batch_update_compass action.

I can think of two ways to avoid this:

  • check for valid outstanding deployment when this message is entered on a queue
  • check during the BytesToSign building

The latter would more secure (maybe), but there is no infrastructure there at all.

Looking into the first.

@byte-bandit byte-bandit self-assigned this Aug 22, 2024
@byte-bandit byte-bandit modified the milestones: v2.1.1, v2.1.2 Aug 23, 2024
taariq pushed a commit to palomachain/paloma that referenced this issue Aug 29, 2024
# Related Github tickets

- VolumeFi#1960
- VolumeFi#1951
- VolumeFi#1956
- VolumeFi#2043

# Background

This change makes use of the atomic handover endpoint on compass,
re-enables the token relink and ensures ownership of fee manager is
transferred as well.

# Testing completed

- [x] test coverage exists or has been added/updated
- [x] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.
byte-bandit added a commit to palomachain/paloma that referenced this issue Aug 30, 2024
# Related Github tickets

- VolumeFi#1960
- VolumeFi#1951
- VolumeFi#1956
- VolumeFi#2043

# Background

This change makes use of the atomic handover endpoint on compass,
re-enables the token relink and ensures ownership of fee manager is
transferred as well.

# Testing completed

- [x] test coverage exists or has been added/updated
- [x] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.
@byte-bandit byte-bandit modified the milestones: v2.1.2, v2.1.3 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant