Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 1.16.0 Roll out plan #1891

Closed
byte-bandit opened this issue Jul 19, 2024 · 4 comments
Closed

🚧 1.16.0 Roll out plan #1891

byte-bandit opened this issue Jul 19, 2024 · 4 comments

Comments

@byte-bandit
Copy link

byte-bandit commented Jul 19, 2024

There is likely a lot of edge cases I haven't thought about yet.

For example, after the upgrade to Paloma 1.16.0, we will need to deploy a new version of compass, immediately. All calls to the old version of compass will fail (since Pigeon will already use the new syntax). This is a problem, since we need to make calls to old compass in order to update the token ownership.

We also won't have any governance yet for exchanges, nor will we have the fee manager contract deployed.

The most obvious solution to the problems outlined above is a multi stage release, something like this:

  • release 1: introduce options to upgrade consensus and upload fee manager (might need small compass upgrade), make sure user fees are set and metrics collected
  • release 2: deploy new (full) compass, pigeon can distinguish between compass versions and makes calls accordingly to which version is needed (old compass, new compass)
  • release 3: flip ownership of tokens and fee manager contracts, enable new compass usage

Also:

We want the Node Sale to be the only price for GRAINS. As such, we want to delay the launching of the GRAIN pools until AFTER the Node Sale is complete. We won't be able to control the DEX price and our floor price for Paloma is an FDV of $5MM.

Thus, we want Pigeon Feed to launch, but holding of the relay fees until we "FEE SWITCH" with a launch of the Pools after the node sale completes.

There's probably still stuff missing in this plan, but it gives an idea of what's needed.

@verabehr
Copy link

from discussion with Christian and Taariq:

  • we will stop the bot backend scripts about an hour before upgrade and then restart so we don't risk a malformatted SLC message
  • we will not worry about migrating any currently deployed test tokens. Vera will send all tokens back to Paloma before the upgrade

@maharifu
Copy link

Even if we don't want to move test tokens, since we have them set, paloma will still try to move them. This will fail since (new) pigeon won't be compatible with (old) compass, so we will still need to deal with this.

Can we disable this mechanism in 1.16.0 and re-enable it in 1.16.1? This might be the faster option to allow us to deploy now.

@verabehr
Copy link

disabling works for me. We plan to move the tokens back to Paloma and end testing once the vote for the weights has passed and relaying is unblocked again

maharifu added a commit to palomachain/paloma that referenced this issue Aug 7, 2024
# Related Github tickets

- VolumeFi#1891

# Background

Even if we don't want to move test tokens, since we have them set,
paloma will still try to move them. This will fail since (new) pigeon
won't be compatible with (old) compass, so we need to disable this
functionality before compass 2.0 is deployed and re-enable it again
afterwards.

# Testing completed

- [ ] test coverage exists or has been added/updated
- [ ] tested in a private testnet

# Breaking changes

- [ ] I have checked my code for breaking changes
- [ ] If there are breaking changes, there is a supporting migration.
maharifu added a commit that referenced this issue Aug 16, 2024
- #1891

Even if we don't want to move test tokens, since we have them set,
paloma will still try to move them. This will fail since (new) pigeon
won't be compatible with (old) compass, so we need to disable this
functionality before compass 2.0 is deployed and re-enable it again
afterwards.

- [ ] test coverage exists or has been added/updated
- [ ] tested in a private testnet

- [ ] I have checked my code for breaking changes
- [ ] If there are breaking changes, there is a supporting migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants