-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 1.16.0 Roll out plan #1891
Comments
from discussion with Christian and Taariq:
|
Even if we don't want to move test tokens, since we have them set, paloma will still try to move them. This will fail since (new) pigeon won't be compatible with (old) compass, so we will still need to deal with this. Can we disable this mechanism in 1.16.0 and re-enable it in 1.16.1? This might be the faster option to allow us to deploy now. |
disabling works for me. We plan to move the tokens back to Paloma and end testing once the vote for the weights has passed and relaying is unblocked again |
# Related Github tickets - VolumeFi#1891 # Background Even if we don't want to move test tokens, since we have them set, paloma will still try to move them. This will fail since (new) pigeon won't be compatible with (old) compass, so we need to disable this functionality before compass 2.0 is deployed and re-enable it again afterwards. # Testing completed - [ ] test coverage exists or has been added/updated - [ ] tested in a private testnet # Breaking changes - [ ] I have checked my code for breaking changes - [ ] If there are breaking changes, there is a supporting migration.
- #1891 Even if we don't want to move test tokens, since we have them set, paloma will still try to move them. This will fail since (new) pigeon won't be compatible with (old) compass, so we need to disable this functionality before compass 2.0 is deployed and re-enable it again afterwards. - [ ] test coverage exists or has been added/updated - [ ] tested in a private testnet - [ ] I have checked my code for breaking changes - [ ] If there are breaking changes, there is a supporting migration.
There is likely a lot of edge cases I haven't thought about yet.
For example, after the upgrade to
Paloma 1.16.0
, we will need to deploy a new version of compass, immediately. All calls to the old version of compass will fail (since Pigeon will already use the new syntax). This is a problem, since we need to make calls to old compass in order to update the token ownership.We also won't have any governance yet for exchanges, nor will we have the fee manager contract deployed.
The most obvious solution to the problems outlined above is a multi stage release, something like this:
Also:
There's probably still stuff missing in this plan, but it gives an idea of what's needed.
The text was updated successfully, but these errors were encountered: