Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConsensusMocks add GetMsgById #1490

Closed
byte-bandit opened this issue Apr 24, 2024 · 0 comments
Closed

ConsensusMocks add GetMsgById #1490

byte-bandit opened this issue Apr 24, 2024 · 0 comments
Assignees
@byte-bandit
Labels
enhancement New feature or request paloma

Comments

@byte-bandit
Copy link

byte-bandit commented Apr 24, 2024 •
edited
Loading

This method was added on the server but never created in the mocks because they're unused within Paloma, however they're used within Pigeon.

a) Stop using Paloma mocks within Pigeon
b) Update mocks in Paloma

Option is the only sane thing to do really, but will require more work.
@byte-bandit byte-bandit self-assigned this Apr 24, 2024
@byte-bandit byte-bandit added enhancement New feature or request paloma labels Apr 24, 2024
@byte-bandit byte-bandit mentioned this issue May 21, 2024
Merged
4 tasks
byte-bandit added a commit to palomachain/paloma that referenced this issue May 21, 2024
@byte-bandit
chore: add missing consensus query mocks (#1167)
0df4a10 
# Related Github tickets

- VolumeFi#1490

# Background

Updates mocks used by `pigeon`.

# Testing completed

- [x] test coverage exists or has been added/updated
- [ ] tested in a private testnet

# Breaking changes

- [x] I have checked my code for breaking changes
- [x] If there are breaking changes, there is a supporting migration.
@verabehr verabehr closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@byte-bandit byte-bandit

Labels
enhancement New feature or request paloma
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@byte-bandit @verabehr