Bugfix 1378 Tooltip incorrect display. #1871
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tooltip currently does not update value (e.g. artist) is currently already in state. This can effectively be solved by no longer immediately returning when the value is known, but also comparing its id against the current supplied id.
|
It's useful to mention the issue (#1378) in the PR description so that GitHub can link the two together and make it easier to navigate to the relevant issue. |
Got it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltip currently does not update value (e.g. artist) is currently already in state. This can effectively be solved by no longer immediately returning when the value is known, but also comparing its id against the current supplied id.
Concerning: #1378