Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TBCCT-138] FE - layout implementation CustomProject page #108

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

[TBCCT-138] FE - layout implementation CustomProject page #108

wants to merge 13 commits into from
+1,717 −11

Conversation

atrincas
Copy link
Collaborator

@atrincas atrincas commented Nov 19, 2024 •
edited
Loading

  • Added topbar with save project button
  • Added project summary view (mock data)
  • Added cards for "project details", "Total project cost", "Leftover after OpEx" (mock data)
  • Added cost details view (mock data + WIP)
  • Annual project cash flow WIP

Jira

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tnc-blue-carbon-cost-tool-ghps ❌ Failed (Inspect) Nov 27, 2024 10:16am

@andresgnlez andresgnlez changed the title FE - layout implementation CustomProject page - DRAFT [TBCCT-138] FE - layout implementation CustomProject page - DRAFT Nov 20, 2024
@atrincas atrincas force-pushed the TBCCT-138-fe-layout-implementation branch from 476ec9d to 76b3a8e Compare November 25, 2024 07:47
@atrincas atrincas changed the title [TBCCT-138] FE - layout implementation CustomProject page - DRAFT [TBCCT-138] FE - layout implementation CustomProject page Nov 25, 2024
@atrincas atrincas marked this pull request as ready for review November 25, 2024 08:01
@andresgnlez
Copy link
Member

image
Here the items need to "breath" a bit more (add some vertical padding)

andresgnlez
andresgnlez reviewed Nov 25, 2024
View reviewed changes
client/src/containers/projects/custom-project/header/parameters/index.tsx
],
},
{
key: FILTER_KEYS[2],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use referenced key here as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

andresgnlez
andresgnlez requested changes Nov 25, 2024
View reviewed changes
Copy link
Member

@andresgnlez andresgnlez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@atrincas atrincas force-pushed the TBCCT-138-fe-layout-implementation branch from a4b72f9 to 993a484 Compare November 26, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresgnlez andresgnlez andresgnlez requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
front-end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atrincas @andresgnlez