Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story/sirh 181 #152

Merged
merged 16 commits into from
Nov 8, 2024
Merged

Story/sirh 181 #152

merged 16 commits into from
Nov 8, 2024

Conversation

alepefe-vizz
Copy link
Collaborator

@alepefe-vizz alepefe-vizz commented Nov 6, 2024

This pull request includes several updates to the api and shared modules, focusing on enhancing data handling, improving code clarity, and updating schemas. Key changes include adding new visualizations, refactoring data processing methods, and updating type definitions.

Enhancements to Data Handling:

  • Added a new visualization type map and set it as the default visualization in the sections.json file.
  • Introduced new methods addChartDataToWidget, addMapDataToWidget, and addBreakdownDataToWidget to handle different types of data processing for widgets. [1] [2] [3]

Code Refactoring:

  • Renamed appendBaseWidgetData to addDataToWidget and updated its logic to handle different data types more efficiently. [1] [2]
  • Updated method and parameter names for consistency, such as changing WidgetDataFilters to WidgetDataFilter and updating related functions. [1] [2] [3] [4]

Schema Updates:

  • Updated schema imports and references to align with the new naming conventions, such as SearchWidgetDataFiltersSchema. [1] [2] [3] [4]

Test Enhancements:

  • Added new test cases to verify the data breakdown functionality and handle scenarios where the breakdown indicator does not exist. [1] [2]

Contract Updates:

  • Added a 500 status code response to various endpoints in the auth.contract.ts file to handle server errors more gracefully. [1] [2] [3]

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
4-growth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 4:12pm

@alepefe-vizz alepefe-vizz merged commit 3caf3f8 into dev Nov 8, 2024
5 checks passed
@alepefe-vizz alepefe-vizz deleted the story/SIRH-181 branch November 8, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants