chore(api): Add "N/A" inside the posible answers of a categorical que… #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stion and ensure all survey questions have answers
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ghost
requested review from
alexeh
reviewed
Oct 28, 2024
alexeh
approved these changes
Oct 28, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the survey data transformation process and the filters used in the survey. The key changes involve adding new options to the survey filters and ensuring all survey questions have answers.
Updates to Survey Filters:
api/data/filters.sql: Added 'N/A' options to various survey filters to accommodate cases where the provided options do not apply.Enhancements to Survey Data Transformation:
api/data/surveys/transform.ts:EXCLUDED_QUESTIONSobject with aQUESTIONSset that lists all survey questions to ensure completeness.generateSurveyQuestionMapfunction to map survey questions to their respective survey IDs.ensureAllSurveyQuestionsHaveAnswersfunction to fill in 'N/A' for any unanswered survey questions.ensureAllSurveyQuestionsHaveAnswersand filter out excluded questions using the new set-based approach.