-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve widget data retrieval #140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… allow devs to retrieve data fora single widget
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alepefe-vizz
force-pushed
the
improve-widget-data-retrieval
branch
from
October 23, 2024 17:16
d7b556c
to
3d1e0e4
Compare
alepefe-vizz
force-pushed
the
improve-widget-data-retrieval
branch
from
October 23, 2024 17:20
3d1e0e4
to
db6cc3d
Compare
alexeh
reviewed
Oct 24, 2024
alexeh
reviewed
Oct 24, 2024
alepefe-vizz
force-pushed
the
improve-widget-data-retrieval
branch
from
October 24, 2024 09:14
db6cc3d
to
6837370
Compare
…t so they are in line with the latest survey
alepefe-vizz
force-pushed
the
improve-widget-data-retrieval
branch
from
October 24, 2024 13:54
714f39d
to
6146310
Compare
alexeh
reviewed
Oct 25, 2024
alexeh
reviewed
Oct 25, 2024
alexeh
reviewed
Oct 25, 2024
alexeh
reviewed
Oct 25, 2024
alexeh
reviewed
Oct 25, 2024
alexeh
reviewed
Oct 25, 2024
alexeh
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alepefe-vizz
Since you decided not to apply some suggested changes as part of the implementation of the widget data retrieval, I won't push for that anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important changes to improve the data handling and retrieval processes in the survey data repository and widgets service. The changes include refactoring the data source manager, enhancing the survey data repository, and updating the widgets service to support new functionalities.
Refactoring and Dependency Management:
SQLAdapter
dependency from theDataSourceManager
class and updated the constructor accordingly (api/src/infrastructure/data-source-manager.ts
). [1] [2]Enhancements to Survey Data Repository:
addSurveyDataToBaseWidget
to thePostgresSurveyDataRepository
class for adding survey data to a base widget (api/src/infrastructure/postgres-survey-data.repository.ts
).answersTable
variable to be a class property and updated all relevant methods to usethis.answersTable
(api/src/infrastructure/postgres-survey-data.repository.ts
). [1] [2] [3] [4]Updates to Widgets Service:
findWidgetWithDataById
to theWidgetsService
class to retrieve a widget with its associated data by its ID (api/src/modules/widgets/widgets.service.ts
).ISurveyDataRepository
dependency into theWidgetsService
class and updated the constructor accordingly (api/src/modules/widgets/widgets.service.ts
).Test Enhancements:
base-widgets.spec.ts
file (api/test/e2e/widgets/base-widgets.spec.ts
).createBaseWidget
function to ensure the creation ofQuestionIndicatorMap
if it does not exist (shared/lib/entity-mocks.ts
). [1] [2]Dependency Injection and Module Configuration:
PostgresSurveyDataRepository
andSQLAdapter
in theWidgetsModule
and updated the providers array accordingly (api/src/modules/widgets/widgets.module.ts
).These changes collectively enhance the functionality and maintainability of the survey data handling and widget retrieval processes.