refactor(api): Add a symbol for SurveyDataRepository provider

Vizzuality · Oct 24, 2024 · 4a8a2c7 · 4a8a2c7
1 parent 6837370
commit 4a8a2c7
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 6 deletions.
diff --git a/api/src/infrastructure/survey-data-repository.interface.ts b/api/src/infrastructure/survey-data-repository.interface.ts
@@ -5,6 +5,9 @@ import {
 import { BaseWidgetWithData } from '@shared/dto/widgets/base-widget-data.interface';
 import { BaseWidget } from '@shared/dto/widgets/base-widget.entity';
 import { WidgetDataFilter } from '@shared/dto/widgets/widget-data-filter';
+
+export const SurveyDataRepository = Symbol('ISurveyDataRepository');
+
 export interface ISurveyDataRepository {
   addSurveyDataToSections(
     sections: Partial<Section>[],

diff --git a/api/src/modules/sections/sections.module.ts b/api/src/modules/sections/sections.module.ts
@@ -6,12 +6,13 @@ import { TypeOrmModule } from '@nestjs/typeorm';
 import { AuthModule } from '@api/modules/auth/auth.module';
 import { PostgresSurveyDataRepository } from '@api/infrastructure/postgres-survey-data.repository';
 import { SQLAdapter } from '@api/infrastructure/sql-adapter';
+import { SurveyDataRepository } from '@api/infrastructure/survey-data-repository.interface';
 
 @Module({
   imports: [TypeOrmModule.forFeature([Section]), forwardRef(() => AuthModule)],
   providers: [
     SQLAdapter,
-    { provide: 'SurveyDataRepository', useClass: PostgresSurveyDataRepository },
+    { provide: SurveyDataRepository, useClass: PostgresSurveyDataRepository },
     SectionsService,
   ],
   controllers: [SectionsController],

diff --git a/api/src/modules/sections/sections.service.ts b/api/src/modules/sections/sections.service.ts
@@ -8,7 +8,10 @@ import {
   SectionWithDataWidget,
 } from '@shared/dto/sections/section.entity';
 import { FetchSpecification } from 'nestjs-base-service';
-import { ISurveyDataRepository } from '@api/infrastructure/survey-data-repository.interface';
+import {
+  ISurveyDataRepository,
+  SurveyDataRepository,
+} from '@api/infrastructure/survey-data-repository.interface';
 import { WidgetDataFiltersSchema } from '@shared/schemas/widget-data-filters.schema';
 
 @Injectable()
@@ -21,7 +24,7 @@ export class SectionsService extends AppBaseService<
   public constructor(
     @InjectRepository(Section)
     private readonly sectionsRepository: Repository<SectionWithDataWidget>,
-    @Inject('SurveyDataRepository')
+    @Inject(SurveyDataRepository)
     private readonly surveyDataRepository: ISurveyDataRepository,
   ) {
     super(sectionsRepository, 'section', 'sections');

diff --git a/api/src/modules/widgets/widgets.module.ts b/api/src/modules/widgets/widgets.module.ts
@@ -12,6 +12,7 @@ import { WidgetsController } from '@api/modules/widgets/widgets.controller';
 import { WidgetsService } from '@api/modules/widgets/widgets.service';
 import { PostgresSurveyDataRepository } from '@api/infrastructure/postgres-survey-data.repository';
 import { SQLAdapter } from '@api/infrastructure/sql-adapter';
+import { SurveyDataRepository } from '@api/infrastructure/survey-data-repository.interface';
 
 @Module({
   imports: [
@@ -20,7 +21,7 @@ import { SQLAdapter } from '@api/infrastructure/sql-adapter';
   ],
   providers: [
     SQLAdapter,
-    { provide: 'SurveyDataRepository', useClass: PostgresSurveyDataRepository },
+    { provide: SurveyDataRepository, useClass: PostgresSurveyDataRepository },
     CustomWidgetService,
     PageFiltersService,
     WidgetsService,

diff --git a/api/src/modules/widgets/widgets.service.ts b/api/src/modules/widgets/widgets.service.ts
@@ -8,7 +8,10 @@ import { FetchSpecification } from 'nestjs-base-service';
 import { WidgetVisualisationFilters } from '@shared/schemas/widget-visualisation-filters.schema';
 import { BaseWidgetWithData } from '@shared/dto/widgets/base-widget-data.interface';
 import { WidgetDataFiltersSchema } from '@shared/schemas/widget-data-filters.schema';
-import { ISurveyDataRepository } from '@api/infrastructure/survey-data-repository.interface';
+import {
+  ISurveyDataRepository,
+  SurveyDataRepository,
+} from '@api/infrastructure/survey-data-repository.interface';
 
 @Injectable()
 export class WidgetsService extends AppBaseService<
@@ -22,7 +25,7 @@ export class WidgetsService extends AppBaseService<
     protected readonly logger: Logger,
     @InjectRepository(BaseWidget)
     private baseWidgetRepository: Repository<BaseWidget>,
-    @Inject('SurveyDataRepository')
+    @Inject(SurveyDataRepository)
     private readonly surveyDataRepository: ISurveyDataRepository,
   ) {
     super(baseWidgetRepository, 'baseWidget', 'baseWidgets');