Strict Types update

Code reformat
VitexSoftware · Dec 1, 2024 · 0fab93c · 0fab93c
1 parent badc593
commit 0fab93c
Show file tree

Hide file tree

Showing 14 changed files with 118 additions and 118 deletions.
diff --git a/.openapi-generator/templates/Statementor.mustache b/.openapi-generator/templates/Statementor.mustache
@@ -42,11 +42,11 @@ class Statementor extends \Ease\Sand
         if ($accountNumber) {
             $this->setAccountNumber($accountNumber);
         }
-        
-        if ($scope){
+
+        if ($scope) {
             $this->setScope($scope);
         }
-        
+
     }
 
     /**
@@ -71,7 +71,7 @@ class Statementor extends \Ease\Sand
      *
      * @return array
      */
-    public function getStatements($currencyCode = 'CZK', $statementLine = 'MAIN')
+    public function getStatements($currencyCode = 'CZK', $statementLine = 'MAIN'): array
     {
         $apiInstance = new PremiumAPI\GetStatementListApi();
         $page = 0;
@@ -213,13 +213,13 @@ class Statementor extends \Ease\Sand
      * Save Statement PDF files
      *
      * @param string $saveTo
-     * @param array  $statements
+     * @param array<mixed>  $statements - produced by getStatements() function
      * @param string $format pdf|xml
      * @param string $currencyCode
      *
-     * @return string
+     * @return array
      */
-    public function download(string $saveTo, array $statements, $format = 'pdf', $currencyCode = 'CZK')
+    public function download(string $saveTo, array $statements, string $format = 'pdf', string $currencyCode = 'CZK'): array
     {
         $saved = [];
         $apiInstance = new PremiumAPI\DownloadStatementApi();
@@ -252,7 +252,7 @@ class Statementor extends \Ease\Sand
      *
      * @return \DateTime
      */
-    public function getSince()
+    public function getSince(): \DateTime
     {
         return $this->since;
     }
@@ -262,7 +262,7 @@ class Statementor extends \Ease\Sand
      *
      * @return \DateTime
      */
-    public function getUntil()
+    public function getUntil(): \DateTime
     {
         return $this->until;
     }

diff --git a/debian/composer.json b/debian/composer.json
@@ -1,7 +1,7 @@
 {
   "name": "deb/rbczpremiumapi",
   "description": "An Core of PHP Framework for Ease of writing Applications (debianized)",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "authors": [
     {
       "name": "Vítězslav Dvořák",

diff --git a/examples/download-statements.php b/examples/download-statements.php
@@ -14,11 +14,11 @@
  * Get today's transactions list
  */
 \Ease\Shared::init(['CERT_PASS', 'XIBMCLIENTID', 'ACCOUNT_NUMBER'], isset($argv[1]) ? $argv[1] : '../.env');
-ApiClient::checkCertificatePresence(\Ease\Functions::cfg('CERT_FILE'));
-$engine = new Statementor(\Ease\Functions::cfg('ACCOUNT_NUMBER'));
-$engine->setScope(\Ease\Functions::cfg('STATEMENT_IMPORT_SCOPE', 'last_month'));
+ApiClient::checkCertificatePresence(\Ease\Shared::cfg('CERT_FILE'));
+$engine = new Statementor(\Ease\Shared::cfg('ACCOUNT_NUMBER'));
+$engine->setScope(\Ease\Shared::cfg('STATEMENT_IMPORT_SCOPE', 'last_month'));
 
-$saveTo = \Ease\Functions::cfg('STATEMENT_SAVE_DIR', './');
+$saveTo = \Ease\Shared::cfg('STATEMENT_SAVE_DIR', './');
 
 if (file_exists($saveTo) === false) {
     mkdir($saveTo, 0777, true);

diff --git a/lib/ApiClient.php b/lib/ApiClient.php
@@ -149,10 +149,10 @@ public static function sourceString()
     /**
      * Try to check certificate readibilty
      *
-     * @throws Exception - Certificate file not found
      *
      * @param string  $certFile path to certificate
      * @param boolean $die      throw exception or return false ?
+     * @throws Exception - Certificate file not found
      *
      * @return boolean certificate file
      */

diff --git a/lib/ObjectSerializer.php b/lib/ObjectSerializer.php
@@ -193,12 +193,12 @@ private static function isEmptyValue($value, string $openApiType): bool
             case 'float':
                 return $value !== 0 && $value !== 0.0;
 
-            # For boolean values, '' is considered empty
+                # For boolean values, '' is considered empty
             case 'bool':
             case 'boolean':
                 return !in_array($value, [false, 0], true);
 
-            # For all the other types, any value at this point can be considered empty.
+                # For all the other types, any value at this point can be considered empty.
             default:
                 return true;
         }
@@ -239,7 +239,7 @@ public static function toQueryValue(
         }
 
         # Handle DateTime objects in query
-        if ( (($openApiType === "\\DateTime") || $openApiType === 'string')  && $value instanceof \DateTime) {
+        if ((($openApiType === "\\DateTime") || $openApiType === 'string')  && $value instanceof \DateTime) {
             return ["{$paramName}" => $value->format(self::$dateTimeFormat)];
         }
 
@@ -294,7 +294,7 @@ public static function toQueryValue(
      */
     public static function convertBoolToQueryStringFormat(bool $value)
     {
-        if (Configuration::BOOLEAN_FORMAT_STRING == Configuration::getDefaultConfiguration()->getBooleanFormatForQueryString()) {
+        if (Configuration::BOOLEAN_FORMAT_STRING === Configuration::getDefaultConfiguration()->getBooleanFormatForQueryString()) {
             return $value ? 'true' : 'false';
         }
 

diff --git a/lib/PremiumAPI/DownloadStatementApi.php b/lib/PremiumAPI/DownloadStatementApi.php
@@ -97,12 +97,12 @@ class DownloadStatementApi
         ],
     ];
 
-/**
-     * @param ClientInterface $client
-     * @param Configuration   $config
-     * @param HeaderSelector  $selector
-     * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
-     */
+    /**
+         * @param ClientInterface $client
+         * @param Configuration   $config
+         * @param HeaderSelector  $selector
+         * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
+         */
     public function __construct(
         ClientInterface $client = null,
         Configuration $config = null,

diff --git a/lib/PremiumAPI/GetAccountBalanceApi.php b/lib/PremiumAPI/GetAccountBalanceApi.php
@@ -97,12 +97,12 @@ class GetAccountBalanceApi
         ],
     ];
 
-/**
-     * @param ClientInterface $client
-     * @param Configuration   $config
-     * @param HeaderSelector  $selector
-     * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
-     */
+    /**
+         * @param ClientInterface $client
+         * @param Configuration   $config
+         * @param HeaderSelector  $selector
+         * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
+         */
     public function __construct(
         ClientInterface $client = null,
         Configuration $config = null,

diff --git a/lib/PremiumAPI/GetAccountsApi.php b/lib/PremiumAPI/GetAccountsApi.php
@@ -97,12 +97,12 @@ class GetAccountsApi
         ],
     ];
 
-/**
-     * @param ClientInterface $client
-     * @param Configuration   $config
-     * @param HeaderSelector  $selector
-     * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
-     */
+    /**
+         * @param ClientInterface $client
+         * @param Configuration   $config
+         * @param HeaderSelector  $selector
+         * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
+         */
     public function __construct(
         ClientInterface $client = null,
         Configuration $config = null,

diff --git a/lib/PremiumAPI/GetBatchDetailApi.php b/lib/PremiumAPI/GetBatchDetailApi.php
@@ -97,12 +97,12 @@ class GetBatchDetailApi
         ],
     ];
 
-/**
-     * @param ClientInterface $client
-     * @param Configuration   $config
-     * @param HeaderSelector  $selector
-     * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
-     */
+    /**
+         * @param ClientInterface $client
+         * @param Configuration   $config
+         * @param HeaderSelector  $selector
+         * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
+         */
     public function __construct(
         ClientInterface $client = null,
         Configuration $config = null,

diff --git a/lib/PremiumAPI/GetStatementListApi.php b/lib/PremiumAPI/GetStatementListApi.php
@@ -97,12 +97,12 @@ class GetStatementListApi
         ],
     ];
 
-/**
-     * @param ClientInterface $client
-     * @param Configuration   $config
-     * @param HeaderSelector  $selector
-     * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
-     */
+    /**
+         * @param ClientInterface $client
+         * @param Configuration   $config
+         * @param HeaderSelector  $selector
+         * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
+         */
     public function __construct(
         ClientInterface $client = null,
         Configuration $config = null,

diff --git a/lib/PremiumAPI/GetTransactionListApi.php b/lib/PremiumAPI/GetTransactionListApi.php
@@ -97,12 +97,12 @@ class GetTransactionListApi
         ],
     ];
 
-/**
-     * @param ClientInterface $client
-     * @param Configuration   $config
-     * @param HeaderSelector  $selector
-     * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
-     */
+    /**
+         * @param ClientInterface $client
+         * @param Configuration   $config
+         * @param HeaderSelector  $selector
+         * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
+         */
     public function __construct(
         ClientInterface $client = null,
         Configuration $config = null,

diff --git a/lib/PremiumAPI/UploadPaymentsApi.php b/lib/PremiumAPI/UploadPaymentsApi.php
@@ -97,12 +97,12 @@ class UploadPaymentsApi
         ],
     ];
 
-/**
-     * @param ClientInterface $client
-     * @param Configuration   $config
-     * @param HeaderSelector  $selector
-     * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
-     */
+    /**
+         * @param ClientInterface $client
+         * @param Configuration   $config
+         * @param HeaderSelector  $selector
+         * @param int             $hostIndex (Optional) host index to select the list of hosts if defined in the OpenAPI spec
+         */
     public function __construct(
         ClientInterface $client = null,
         Configuration $config = null,

diff --git a/lib/Statementor.php b/lib/Statementor.php
@@ -42,11 +42,11 @@ public function __construct(string $accountNumber = '', string $scope = '')
         if ($accountNumber) {
             $this->setAccountNumber($accountNumber);
         }
-        
-        if ($scope){
+
+        if ($scope) {
             $this->setScope($scope);
         }
-        
+
     }
 
     /**
@@ -71,7 +71,7 @@ public function setAccountNumber($accountNumber)
      *
      * @return array
      */
-    public function getStatements($currencyCode = 'CZK', $statementLine = 'MAIN')
+    public function getStatements($currencyCode = 'CZK', $statementLine = 'MAIN'): array
     {
         $apiInstance = new PremiumAPI\GetStatementListApi();
         $page = 0;
@@ -213,13 +213,13 @@ public function setScope(string $scope): void
      * Save Statement PDF files
      *
      * @param string $saveTo
-     * @param array  $statements
+     * @param array<mixed>  $statements - produced by getStatements() function
      * @param string $format pdf|xml
      * @param string $currencyCode
      *
-     * @return string
+     * @return array
      */
-    public function download(string $saveTo, array $statements, $format = 'pdf', $currencyCode = 'CZK')
+    public function download(string $saveTo, array $statements, string $format = 'pdf', string $currencyCode = 'CZK'): array
     {
         $saved = [];
         $apiInstance = new PremiumAPI\DownloadStatementApi();
@@ -252,7 +252,7 @@ public function download(string $saveTo, array $statements, $format = 'pdf', $cu
      *
      * @return \DateTime
      */
-    public function getSince()
+    public function getSince(): \DateTime
     {
         return $this->since;
     }
@@ -262,7 +262,7 @@ public function getSince()
      *
      * @return \DateTime
      */
-    public function getUntil()
+    public function getUntil(): \DateTime
     {
         return $this->until;
     }