Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(invokeazurerequest): ⚡ removed string concatenation #12

Merged
merged 3 commits into from
Dec 21, 2023
Merged

perf(invokeazurerequest): ⚡ removed string concatenation #12

merged 3 commits into from
Dec 21, 2023

Conversation

prubis
Copy link
Contributor

@prubis prubis commented Dec 19, 2023

Much faster and far less memory usage through sending objects down the pipeline rather than concatting strings. Discovered this perf issue when I was trying to use Get-MDEMachine in an environment with tens of thousands of enrolled machines.

Much faster and far less memory usage through sending objects down the 
pipeline rather than concatting.
@prubis
Copy link
Contributor Author

prubis commented Dec 19, 2023

Hi @itpropro , I think the failing check was happening even before my PR, could you please take a look?

@itpropro
Copy link
Contributor

Hey,
Good find and nice performance improvement!
The failing test seems unrelated to your commit, I will fix it and merge your changes today.

@itpropro itpropro added good first issue Good for newcomers enhancement New feature or request labels Dec 20, 2023
@itpropro
Copy link
Contributor

Have you updated the wiki submodule @prubis ?
If not, please execute

Set-Location wiki
git pull
Set-Location ..

And commit. After that I can merge :)

@prubis
Copy link
Contributor Author

prubis commented Dec 20, 2023

Hmm, I didn't make any changes in the wiki so figured it wasn't necessary, but I might have missed something. I've init-ed and updated the wiki, but then there's nothing for me to commit as far as I can tell:

C:\Repos\PSMDE> git submodule update --init --recursive
Submodule 'wiki' (https://github.com/Visorian/PSMDE.wiki.git) registered for path 'wiki'
Cloning into 'C:/Repos/PSMDE/wiki'...
Submodule path 'wiki': checked out '5a7c6b202a1f07c1e3bca0b0021a2310ec36f39e'
C:\Repos\PSMDE> git status
On branch prubis-perf-invokeazurerequest
Your branch is up to date with 'origin/prubis-perf-invokeazurerequest'.

nothing to commit, working tree clean
C:\Repos\PSMDE>

Unless I missed something?

@itpropro itpropro merged commit a03baec into Visorian:main Dec 21, 2023
2 checks passed
@prubis prubis deleted the prubis-perf-invokeazurerequest branch February 22, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants