fix issue 343 (#344)

Vishwanatha-HD · Sep 14, 2022 · 67dbe8d · 67dbe8d
1 parent d2b49bc
commit 67dbe8d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/buffer_go18.go b/buffer_go18.go
@@ -33,7 +33,7 @@ func NewGenericBuffer[T any](options ...RowGroupOption) *GenericBuffer[T] {
 	}
 
 	t := typeOf[T]()
-	if config.Schema == nil {
+	if config.Schema == nil && t != nil {
 		config.Schema = schemaOf(dereference(t))
 	}
 
@@ -53,6 +53,9 @@ func typeOf[T any]() reflect.Type {
 type bufferFunc[T any] func(*GenericBuffer[T], []T) (int, error)
 
 func bufferFuncOf[T any](t reflect.Type, schema *Schema) bufferFunc[T] {
+	if t == nil {
+		return (*GenericBuffer[T]).writeRows
+	}
 	switch t.Kind() {
 	case reflect.Interface, reflect.Map:
 		return (*GenericBuffer[T]).writeRows

diff --git a/buffer_go18_test.go b/buffer_go18_test.go
@@ -181,3 +181,8 @@ func TestIssue327(t *testing.T) {
 		_ = parquet.NewGenericBuffer[testType]()
 	})
 }
+
+func TestIssue343(t *testing.T) {
+	// must not panic
+	_ = parquet.NewGenericBuffer[any]()
+}