Merge pull request #2787 from VisActor/2210-bug-vtable-pivotChart-sel…

…ectenable 2210 bug vtable pivot chart selectenable
VisActor · Nov 11, 2024 · 463d1a6 · 463d1a6
2 parents 9c6ce67 + 06fd8e9
commit 463d1a6
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 13 deletions.
diff --git a/...on/changes/@visactor/vtable/2210-bug-vtable-pivotChart-selectenable_2024-11-07-10-57.json b/...on/changes/@visactor/vtable/2210-bug-vtable-pivotChart-selectenable_2024-11-07-10-57.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "fix: pivot chart spec enable select not work #2210\n\n",
+      "type": "none",
+      "packageName": "@visactor/vtable"
+    }
+  ],
+  "packageName": "@visactor/vtable",
+  "email": "[email protected]"
+}
diff --git a/packages/vtable/src/layout/pivot-header-layout.ts b/packages/vtable/src/layout/pivot-header-layout.ts
@@ -3317,22 +3317,28 @@ export class PivotHeaderLayoutMap implements LayoutMapAPI {
     return state;
   }
   updateDataStateToChartInstance(activeChartInstance?: any): void {
-    if (!activeChartInstance) {
-      activeChartInstance = (this._table as PivotChart)._getActiveChartInstance();
+    if (activeChartInstance?.getSpec().select?.enable !== false) {
+      if (!activeChartInstance) {
+        activeChartInstance = (this._table as PivotChart)._getActiveChartInstance();
+      }
+      const state = this._generateChartState();
+      this._indicators.forEach((_indicatorObject: IndicatorData) => {
+        const chartInstance = _indicatorObject.chartInstance;
+        if (_indicatorObject.chartSpec.select?.enable !== false) {
+          chartInstance.updateState(state);
+        }
+      });
+      activeChartInstance?.updateState(state);
     }
-    const state = this._generateChartState();
-    this._indicators.forEach((_indicatorObject: IndicatorData) => {
-      const chartInstance = _indicatorObject.chartInstance;
-      chartInstance.updateState(state);
-    });
-    activeChartInstance?.updateState(state);
   }
   updateDataStateToActiveChartInstance(activeChartInstance?: any): void {
-    if (!activeChartInstance) {
-      activeChartInstance = (this._table as PivotChart)._getActiveChartInstance();
+    if (activeChartInstance?.getSpec().select?.enable !== false) {
+      if (!activeChartInstance) {
+        activeChartInstance = (this._table as PivotChart)._getActiveChartInstance();
+      }
+      const state = this._generateChartState();
+      activeChartInstance?.updateState(state);
     }
-    const state = this._generateChartState();
-    activeChartInstance?.updateState(state);
   }
 
   /**

diff --git a/packages/vtable/src/scenegraph/graphic/chart.ts b/packages/vtable/src/scenegraph/graphic/chart.ts
@@ -179,7 +179,9 @@ export class Chart extends Group {
 
     (table.internalProps.layoutMap as any)?.updateDataStateToActiveChartInstance?.(this.activeChartInstance);
     this.activeChartInstance.on('click', (params: any) => {
-      if (Chart.temp) {
+      if (this.attribute.spec.select?.enable === false) {
+        table.scenegraph.updateChartState(null);
+      } else if (Chart.temp) {
         table.scenegraph.updateChartState(params?.datum);
       }
     });