Merge pull request #3695 from VisActor/fix/crosshair-cache-value

fix: fix cache of crosshair value when hide crosshair, fix #3686
VisActor · Jan 26, 2025 · 4e64c33 · 4e64c33
2 parents a02c8b2 + 1576f08
commit 4e64c33
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/common/changes/@visactor/vchart/fix-crosshair-cache-value_2025-01-26-06-01.json b/common/changes/@visactor/vchart/fix-crosshair-cache-value_2025-01-26-06-01.json
@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "fix: fix cache of crosshair value when hide crosshair, fix #3686\n\n",
+      "type": "none",
+      "packageName": "@visactor/vchart"
+    }
+  ],
+  "packageName": "@visactor/vchart",
+  "email": "[email protected]"
+}
diff --git a/packages/vchart/src/component/crosshair/cartesian.ts b/packages/vchart/src/component/crosshair/cartesian.ts
@@ -140,7 +140,8 @@ export class CartesianCrossHair<T extends ICartesianCrosshairSpec = ICartesianCr
         y = pos?.y;
       }
     }
-
+    // 删除之前的currValue
+    this.clearAxisValue();
     // 找到所有的包含这个点的轴
     const { xAxisMap, yAxisMap } = this._findAllAxisContains(x, y);
     if ((xAxisMap && xAxisMap.size === 0) || (yAxisMap && yAxisMap.size === 0)) {
@@ -151,8 +152,7 @@ export class CartesianCrossHair<T extends ICartesianCrosshairSpec = ICartesianCr
       this.hide();
       return;
     }
-    // 删除之前的currValue
-    this.clearAxisValue();
+
     // 将数据保存到这个对象中，如果不存在，就直接不执行后续逻辑
     xAxisMap && xAxisMap.size && this._setAllAxisValues(xAxisMap, { x, y }, 'xField');
     yAxisMap && yAxisMap.size && this._setAllAxisValues(yAxisMap, { x, y }, 'yField');

diff --git a/packages/vchart/src/component/crosshair/polar.ts b/packages/vchart/src/component/crosshair/polar.ts
@@ -135,6 +135,8 @@ export class PolarCrossHair<T extends IPolarCrosshairSpec = IPolarCrosshairSpec>
         y = pos.y;
       }
     }
+    // 删除之前的currValue
+    this.clearAxisValue();
 
     // 找到所有的包含这个点的轴
     const { angleAxisMap, radiusAxisMap } = this._findAllAxisContains(x, y);
@@ -146,8 +148,7 @@ export class PolarCrossHair<T extends IPolarCrosshairSpec = IPolarCrosshairSpec>
       this.hide();
       return;
     }
-    // 删除之前的currValue
-    this.clearAxisValue();
+
     // 将数据保存到这个对象中，如果不存在，就直接不执行后续逻辑
     angleAxisMap && this._setAllAxisValues(angleAxisMap, { x, y }, 'categoryField');
     radiusAxisMap && this._setAllAxisValues(radiusAxisMap, { x, y }, 'valueField');