Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run process in background #747

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Run process in background #747

merged 2 commits into from
Mar 28, 2022

Conversation

lwronski
Copy link
Contributor

@lwronski lwronski commented Mar 2, 2022

No description provided.

@lwronski lwronski linked an issue Mar 2, 2022 that may be closed by this pull request
Can run --watch send ctrl+c on source changes? #711
Closed
alexarchambault
alexarchambault reviewed Mar 2, 2022
View reviewed changes
Copy link
Contributor

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if we want to enable that by default, it might be a bit surprising… Better only enable it when a new option, such as --revolver (as a reference to sbt-revolver) is passed (and --revolver would automatically enable watch mode too).

modules/cli/src/main/scala/scala/cli/commands/Run.scala Outdated Show resolved Hide resolved
@lwronski lwronski force-pushed the run-watch branch 2 times, most recently from 45c6e4a to faec305 Compare March 7, 2022 16:08
@lwronski lwronski force-pushed the run-watch branch 5 times, most recently from cdc3370 to 6c07492 Compare March 14, 2022 16:02
@lwronski lwronski marked this pull request as ready for review March 14, 2022 16:03
@lwronski lwronski force-pushed the run-watch branch 2 times, most recently from 0616a07 to 23e19e7 Compare March 28, 2022 07:57
@lwronski lwronski merged commit fe21659 into VirtusLab:main Mar 28, 2022
@kubukoz
Copy link
Contributor

kubukoz commented Apr 7, 2022

I feel like --revolver is too obscure of a name, only people already familiar with sbt-revolver will immediately know what it does. Why not name it something closer to what it does like --watch or --restart instead?

@lwronski lwronski mentioned this pull request May 5, 2022
Merged
@Gedochao Gedochao mentioned this pull request Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can run --watch send ctrl+c on source changes?
3 participants
@lwronski @kubukoz @alexarchambault