Support coursier-downloaded scala wrapper tests on Windows
#3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
changed the title
coursier-downloaded scala wrapper tests on Windows
Gedochao
force-pushed
the
maintenance/coursier-installation-tests-on-windows
branch
4 times, most recently
from
dca8274 to
9ec5d3d
Compare
Gedochao
changed the title
coursier-downloaded scala wrapper tests on Windowscoursier-downloaded scala wrapper tests on Windows
|
Note: this (hopefully) might make it easier to reproduce this issue: |
Gedochao
force-pushed
the
maintenance/coursier-installation-tests-on-windows
branch
2 times, most recently
from
f2dc4a0 to
4cf48ae
Compare
Gedochao
force-pushed
the
maintenance/coursier-installation-tests-on-windows
branch
from
4cf48ae to
e338513
Compare
Gedochao
requested review from
kasiaMarek and
tgodzik
and removed request for
tgodzik
tgodzik
approved these changes
Dec 4, 2024
Gedochao
deleted the
maintenance/coursier-installation-tests-on-windows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to run tests with the
scalarunner wrapper coming from acoursierinstallation of the language.We swap out the Scala CLI launcher used in the wrapper for one built for the purpose of our integration tests.
We used to skip running this on Windows until this change.