Don't fail the update-packages and windows-packages jobs on individual distributions' steps
#3288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
force-pushed
the
maintenance/dont-fail-on-individual-distributions
branch
from
4512a98 to
85707be
Compare
…idual distributions' steps
Gedochao
force-pushed
the
maintenance/dont-fail-on-individual-distributions
branch
from
85707be to
79ae378
Compare
tgodzik
approved these changes
Nov 15, 2024
Gedochao
deleted the
maintenance/dont-fail-on-individual-distributions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3273
This wouldn't have prevented the CentOS/Fedora package upload from failing, but it would have allowed the job to still update SDKMAN! (which failed as a ricochet) and execute other following steps.
The downside of this solution is that we'll need to double check the CI if no steps failed.
A potential alternative would be to divide the
update-packagesandwindows-packagesinto smaller jobs, but we are already very GitHub-runner-hungry, so perhaps this is good enough...?