Bump actions/upload-artifact & actions/download-artifact from 3 to 4 #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merging this, we should pay attention if it won't break our test reports, as dorny/test-reporter seems to still rely on the incompatible |
This was referenced Jan 23, 2024
tgodzik
approved these changes
Jan 23, 2024
|
This indeed seems to break our test reports. |
Gedochao
force-pushed
the
maintenance/bump-download-and-upload-artifacts-to-v4
branch
from
941e679 to
dac9627
Compare
Gedochao
force-pushed
the
maintenance/bump-download-and-upload-artifacts-to-v4
branch
from
dac9627 to
8d7bf1f
Compare
|
So this seems to have been fixed in https://github.com/dorny/test-reporter/releases/tag/v1.9.1 (although I'm not exactly sure why), as per dorny/test-reporter#363 (comment). I rebased and re-bumped where applicable, CI is green, it's ready for re-review. |
tgodzik
approved these changes
Dec 3, 2024
Gedochao
deleted the
maintenance/bump-download-and-upload-artifacts-to-v4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2640 & #2641, the bump has to be done in one go.
This is just a squashed commit with the contents of both aforementioned PRs.