Skip to content

Commit

Permalink
Merge pull request #3366 from Gedochao/update/using_directives-1.1.3
Browse files Browse the repository at this point in the history
Improve deprecation warnings for commas with whitespace used as using directive value separators
  • Loading branch information
Gedochao authored Dec 12, 2024
2 parents e333726 + 94c5fe2 commit 5b481bd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -115,14 +115,16 @@ class RunTestsDefault extends RunTestDefinitions
) {
val inputPath = os.rel / "example.sc"
TestInputs(inputPath ->
"""//> using options -Werror, -Wconf:cat=deprecation:e
"""//> using options -Werror, -Wconf:cat=deprecation:e, -Wconf:cat=unused:e
|println("Deprecation warnings should have been printed")
|""".stripMargin)
.fromRoot { root =>
val res = os.proc(TestUtil.cli, "run", extraOptions, inputPath)
.call(cwd = root, stderr = os.Pipe)
val err = res.err.trim()
expect(err.contains("Use of commas as separators is deprecated"))
val err = res.err.trim()
val expectedWarning = "Use of commas as separators is deprecated"
expect(err.contains(expectedWarning))
expect(err.linesIterator.count(_.contains(expectedWarning)) == 2)
}
}
}
2 changes: 1 addition & 1 deletion project/deps.sc
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ object Deps {
val typelevelToolkitVersion = "0.1.29"
def typelevelToolkit = ivy"org.typelevel:toolkit:$typelevelToolkitVersion"
def typelevelToolkitTest = ivy"org.typelevel:toolkit-test:$typelevelToolkitVersion"
def usingDirectives = ivy"org.virtuslab:using_directives:1.1.2"
def usingDirectives = ivy"org.virtuslab:using_directives:1.1.3"
// Lives at https://github.com/VirtusLab/no-crc32-zip-input-stream, see #865
// This provides a ZipInputStream that doesn't verify CRC32 checksums, that users
// can enable by setting SCALA_CLI_VENDORED_ZIS=true in the environment, to workaround
Expand Down

0 comments on commit 5b481bd

Please sign in to comment.