Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Kotlin DSL jvmtarget to 11 #1016

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Set Kotlin DSL jvmtarget to 11 #1016

merged 1 commit into from
Jul 29, 2022

Conversation

MaciejG604
Copy link
Contributor

No description provided.

@MaciejG604 MaciejG604 requested a review from PawelLipski as a code owner July 29, 2022 10:25
@MaciejG604 MaciejG604 linked an issue Jul 29, 2022 that may be closed by this pull request
Improve Gradle-related Kotlin code #1004
Closed
17 tasks
@MaciejG604 MaciejG604 self-assigned this Jul 29, 2022
@PawelLipski PawelLipski added this to the v2.2.0 milestone Jul 29, 2022
@MaciejG604 MaciejG604 merged commit 981c81c into refactor/1004-unverbose-dsl Jul 29, 2022
@MaciejG604 MaciejG604 deleted the chore/fix-kotlin-version-warnings branch July 29, 2022 11:06
@PawelLipski
Copy link
Collaborator

Generally let's only merge PRs once they're based on develop. It doesn't harm much in this case, since both #1016 and its base #1015 are both small. In general, however, merging PR to a non-develop base leads to large, un-focused PRs... which we want to avoid in the first place

PawelLipski pushed a commit that referenced this pull request Jul 29, 2022
@MaciejG604 @PawelLipski
Set Kotlin DSL jvmtarget to 11 (#1016)
10ced0b
PawelLipski pushed a commit that referenced this pull request Aug 1, 2022
@MaciejG604 @PawelLipski
Set Kotlin DSL jvmtarget to 11 (#1016)
f800550
PawelLipski pushed a commit that referenced this pull request Aug 1, 2022
@MaciejG604 @PawelLipski
Set Kotlin DSL jvmtarget to 11 (#1016)
8a0c0e7
PawelLipski pushed a commit that referenced this pull request Aug 1, 2022
@MaciejG604 @PawelLipski
Set Kotlin DSL jvmtarget to 11 (#1016)
669573c
MaciejG604 added a commit that referenced this pull request Aug 2, 2022
@MaciejG604
Set Kotlin DSL jvmtarget to 11 (#1016)
238dc7a
MaciejG604 added a commit that referenced this pull request Aug 3, 2022
@MaciejG604 @PawelLipski
Refactor/1004 simplify libs versions (#1026)
dead3f9 
* Set Kotlin DSL jvmtarget to 11 (#1016)

* Clean up depracations in build code + restore `kotlinOptions.allWarningsAsErrors`

* Add comment to libs.versions.toml

* Remove [plugins] section from libs.versions.toml

* Get rid of kotlin version difference warning

* Update build.gradle.kts

Co-authored-by: Paweł Lipski <[email protected]>

* Apply code review fixes

Co-authored-by: Pawel Lipski <[email protected]>
MaciejG604 added a commit that referenced this pull request Oct 12, 2022
@MaciejG604
Set Kotlin DSL jvmtarget to 11 (#1016)
96ba0c2 
(cherry picked from commit 669573c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PawelLipski PawelLipski PawelLipski approved these changes

Assignees

@MaciejG604 MaciejG604

Labels
build code quality Code quality
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

Improve Gradle-related Kotlin code
2 participants
@MaciejG604 @PawelLipski