Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extension functions to configure subprojects #1014

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

PawelLipski
Copy link
Collaborator

@PawelLipski PawelLipski commented Jul 29, 2022

image

@PawelLipski PawelLipski self-assigned this Jul 29, 2022
@PawelLipski PawelLipski added this to the v2.2.0 milestone Jul 29, 2022
@PawelLipski PawelLipski linked an issue Jul 29, 2022 that may be closed by this pull request
17 tasks
@PawelLipski PawelLipski force-pushed the refactor/1004-project-ext-fun branch from 54c3b36 to 2e24486 Compare July 29, 2022 09:10
@PawelLipski PawelLipski force-pushed the bugfix/1010-separate-catalog-symlink branch from d5a7741 to 4c3ddfd Compare July 29, 2022 09:21
@PawelLipski PawelLipski force-pushed the refactor/1004-project-ext-fun branch from 2e24486 to dc819a8 Compare July 29, 2022 09:21
@PawelLipski PawelLipski force-pushed the bugfix/1010-separate-catalog-symlink branch from 4c3ddfd to 49d2b53 Compare July 29, 2022 17:20
@PawelLipski PawelLipski force-pushed the refactor/1004-project-ext-fun branch from dc819a8 to 56245d8 Compare July 29, 2022 17:23
@@ -1,12 +1,10 @@
import com.virtuslab.gitmachete.buildsrc.BuildUtils
import com.virtuslab.gitmachete.buildsrc.*

plugins {
`java-library`
`java-test-fixtures`
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lombok()

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lombok stays in this module, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, but it's only in testFixtures NVM then. No fix needed here.

@PawelLipski PawelLipski force-pushed the bugfix/1010-separate-catalog-symlink branch from 49d2b53 to 49c624c Compare August 1, 2022 10:12
@PawelLipski PawelLipski force-pushed the refactor/1004-project-ext-fun branch from 56245d8 to 51a8671 Compare August 1, 2022 10:12
@PawelLipski PawelLipski force-pushed the bugfix/1010-separate-catalog-symlink branch from 49c624c to 05a4775 Compare August 1, 2022 10:37
@PawelLipski PawelLipski force-pushed the refactor/1004-project-ext-fun branch from 51a8671 to 1284e6c Compare August 1, 2022 10:37
@PawelLipski PawelLipski force-pushed the bugfix/1010-separate-catalog-symlink branch from 05a4775 to dff5a0b Compare August 1, 2022 12:15
@PawelLipski PawelLipski force-pushed the refactor/1004-project-ext-fun branch from 1284e6c to 666b5c8 Compare August 1, 2022 12:15
Base automatically changed from bugfix/1010-separate-catalog-symlink to develop August 1, 2022 12:38
@PawelLipski PawelLipski merged commit 666b5c8 into develop Aug 1, 2022
@PawelLipski PawelLipski deleted the refactor/1004-project-ext-fun branch August 1, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Gradle-related Kotlin code
2 participants