Use version catalog in buildSrc code #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
mkondratek
approved these changes
Jul 28, 2022
| @@ -1,7 +1,6 @@ | |||
| import org.jetbrains.kotlin.gradle.tasks.KotlinCompile | |||
|
|
|||
| plugins { | |||
| `java-library` | |||
There was a problem hiding this comment.
Was redundant!
| dependencyResolutionManagement { | ||
| versionCatalogs { create("libs") { from(files("../gradle/libs.versions.toml")) } } | ||
| versionCatalogs { | ||
| create("libs") { |
There was a problem hiding this comment.
so we were not using it b4 although the catalog was present, right?
There was a problem hiding this comment.
Yes, exactly, there were only hardcoded references to libs in buildSrc kotlin code
| @@ -92,70 +106,71 @@ object BuildUtils { | |||
|
|
|||
| project.dependencies { | |||
| add("uiTestImplementation", testFixtures(project(":testCommon"))) | |||
| add("uiTestImplementation", "org.virtuslab.ideprobe:junit-driver_2.13:0.36.1") | |||
| add("uiTestImplementation", "org.virtuslab.ideprobe:robot-driver_2.13:0.36.1") | |||
| add("uiTestImplementation", project.bundle("ideProbe")) | |||
There was a problem hiding this comment.
nice. finally it look like człowiek
| import org.checkerframework.gradle.plugin.CheckerFrameworkExtension | ||
| import org.checkerframework.gradle.plugin.CheckerFrameworkPlugin | ||
| import org.gradle.api.Project | ||
| import org.gradle.api.plugins.JavaPluginConvention | ||
| import org.gradle.api.tasks.SourceSet | ||
| import org.gradle.kotlin.dsl.* | ||
|
|
||
| // TODO (#1004): Remove hardcoded dependencies and deprecated code | ||
| // TODO (#1004): Remove deprecated code |
There was a problem hiding this comment.
one check box resolved 😌
PawelLipski
changed the title
PawelLipski
force-pushed
the
refactor/version-catalog-from-buildsrc
branch
from
a455eba to
80534c5
Compare
MaciejG604
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.