Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched UpdateEapBuildNumber to Kotlin #1006

Merged
merged 10 commits into from
Jul 28, 2022
Merged

Switched UpdateEapBuildNumber to Kotlin #1006

merged 10 commits into from
Jul 28, 2022

Conversation

MaciejG604
Copy link
Contributor

No description provided.

@MaciejG604 MaciejG604 added this to the v2.2.0 milestone Jul 28, 2022
@MaciejG604 MaciejG604 self-assigned this Jul 28, 2022
@MaciejG604 MaciejG604 linked an issue Jul 28, 2022 that may be closed by this pull request
Improve Gradle-related Kotlin code #1004
Closed
17 tasks
@MaciejG604
Copy link
Contributor Author

Need to delete spotless for groovy and other groovy left-overs.

@MaciejG604 MaciejG604 marked this pull request as draft July 28, 2022 10:22
PawelLipski
PawelLipski reviewed Jul 28, 2022
View reviewed changes
buildSrc/src/main/kotlin/com/virtuslab/gitmachete/buildsrc/UpdateEapBuildNumber.kt Outdated
@Internal
var intellijSnapshotsUrl: String = "https://www.jetbrains.com/intellij-repository/snapshots/"

@Internal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm if not marked as @Internal... will it automatically be interpreted as @Input or @Output? how does @Internal var differ from an annotation-less var?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no annotation is found gradle throws an error - Gradle Docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool picture description from Gradle Docs
image

@PawelLipski
Copy link
Collaborator

Btw the PR doesn't need to a draft anymore; drafts are typically used to mean "not ready for a detailed review, only for an overall look"

@MaciejG604 MaciejG604 marked this pull request as ready for review July 28, 2022 12:04
PawelLipski
PawelLipski reviewed Jul 28, 2022
View reviewed changes
buildSrc/src/test/kotlin/BuildNumberComparisonTest.kt
@@ -2,23 +2,19 @@ import com.virtuslab.gitmachete.buildsrc.UpdateEapBuildNumber.Companion.buildNum
import org.junit.Test

class BuildNumberComparisonTest {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test triggered anywhere in our current CI pipeline?

Copy link
Contributor Author

@MaciejG604 MaciejG604 Jul 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIC gradle runs all things marked with '@ Test' during build task.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so if you fail a test in buildSrc on purpose, the entire build is broken? that's what really matters here (so that we don't overlook a failure)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the build task fails.

@MaciejG604 MaciejG604 enabled auto-merge (squash) July 28, 2022 13:54
@MaciejG604 MaciejG604 merged commit e931274 into develop Jul 28, 2022
@MaciejG604 MaciejG604 deleted the chore/improve-gradle-related-kotlin-code branch July 28, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PawelLipski PawelLipski PawelLipski approved these changes

@mkondratek mkondratek Awaiting requested review from mkondratek

Assignees

@MaciejG604 MaciejG604

Labels
build code quality Code quality
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

Improve Gradle-related Kotlin code
2 participants
@MaciejG604 @PawelLipski