Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeclared dependency when building with Strapi v4.8.1 #199

Closed
hypnotoad08 opened this issue Mar 16, 2023 · 6 comments
Closed

Undeclared dependency when building with Strapi v4.8.1 #199

hypnotoad08 opened this issue Mar 16, 2023 · 6 comments
Assignees
Labels
bug Something isn't working moderation panel solved Issue has been solved v4 Strapi v4

Comments

@hypnotoad08
Copy link

When running npm run build with Strapi V4.8.1 and strapi-plugin-comments 2.2.8 getting an error during webpack.

Webpack █████████████████████████ building (63%) 1/1 entries 9399/9667 dep
endencies 2243/2723 modules 275 active
...ules@strapi\plugin-users-permissions\admin\src\hooks\useRolesList\reduc
er.js

ModuleNotFoundError: Module not found: Error: Package path ./addon/display/placeholder is not exported from package D:\GitHub\Strapi-test\node_modules\codemirror (see exports field in D:\GitHub\Strapi-test\node_modules\codemirror\package.json)

Opened an issue with Strapi and it was determined the issue is actually with strapi-pluglin-comments - "the issue is with the plugin strapi-plugin-comments, they've used dependencies in their plugin in this case codemirror but they've not declared it in their package.json so the plugin is using our version which is v6 which has breaking changes. So realistically, the plugin author needs to double check all deps they've used are declared in their package.json to avoid this happening in the future." - strapi/strapi#16100

@cyp3rius cyp3rius self-assigned this Mar 16, 2023
@cyp3rius cyp3rius added bug Something isn't working investigation Issue under investigation v4 Strapi v4 labels Mar 16, 2023
@cyp3rius
Copy link
Collaborator

Checking which dependency cause the issue.

@hypnotoad08
Copy link
Author

Checking which dependency cause the issue.

It's codemirror, if I'm not mistaken.

@cyp3rius
Copy link
Collaborator

Right it's directly used in the WYSIWYG Editor from Strapi. Fix should be in 1-2 hours.

@cyp3rius
Copy link
Collaborator

@hypnotoad08 fix releases as part of v2.2.9 with all dependencies declared and upgraded (as well Strapi to 2.2.8)

Issue was caused by the Editor.ts file and dependency in there. We simply copied WYSIWYG from Strapi package without providing declared package (mistake, indeed). All was working till change of codemirror in code as we've been consuming this. Now our plugin is aligned with the Content Manager plugin file and this shouldn't happen.

BTW. Would be nice for Strapi to expose their WYSIWYG as a component to Design System :)

@cyp3rius cyp3rius added solved Issue has been solved and removed in progress labels Mar 17, 2023
@cyp3rius
Copy link
Collaborator

Please check and we'll close the issue.

@hypnotoad08
Copy link
Author

Please check and we'll close the issue.

Can confirm 2.29 resolves the issue, thank you for the prompt fix!

github-actions bot pushed a commit to zrp/uqbar-strapi-plugin-comments that referenced this issue Oct 4, 2023
# [1.1.0](v1.0.2...v1.1.0) (2023-10-04)

### Bug Fixes

* add types to Avatar component ([f12ea9c](f12ea9c))
* author blocked props ([d9d0777](d9d0777))
* author population ([VirtusLab-Open-Source#177](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/177)) ([5ba0d85](5ba0d85))
* change error 403 test ([99ec162](99ec162))
* custom field on existing entity ([VirtusLab-Open-Source#178](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/178)) ([5e6cc63](5e6cc63))
* fixed UserAvatar typing ([dd179c7](dd179c7))
* fixes after merge ([3b9eee2](3b9eee2))
* issue [VirtusLab-Open-Source#199](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/199) - undeclared codemirror dependency causes build crash ([ccc1f98](ccc1f98))
* issue [VirtusLab-Open-Source#201](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/201) fix the filtering by thread ([bdc292a](bdc292a))
* issue [VirtusLab-Open-Source#220](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/220), issue [VirtusLab-Open-Source#221](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/221) ([VirtusLab-Open-Source#222](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/222)) ([03d504a](03d504a))
* load only existing translations ([e0cea8d](e0cea8d))
* package.json outdated ([1ef26e5](1ef26e5))
* peer dependency ([50bd59c](50bd59c))
* stick to older match-sorter dependency following strapi ([70dd408](70dd408))
* strapi 4.13 packages alignment ([VirtusLab-Open-Source#229](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/229)) ([3432cd2](3432cd2))
* strapi v4.7.1 compatibility fix because of dependencies ([563f86c](563f86c))
* unused import removed ([ac7d47f](ac7d47f))

### Features

* **api:** issue [VirtusLab-Open-Source#209](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/209) - find all by author ([e47684a](e47684a))
* author entity props blocking ([VirtusLab-Open-Source#186](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/186)) ([6134f1e](6134f1e))
* basic filters options added to Discover and Reports ([074d23a](074d23a))
* comments custom field [CU-2tn2923] ([VirtusLab-Open-Source#157](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/157)) ([aaac8a0](aaac8a0)), closes [VirtusLab-Open-Source#158](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/158)
* create reports page [CU-20rfmkv] ([VirtusLab-Open-Source#153](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/153)) ([15b9b57](15b9b57))
* custom fields on server-side [CU-xhcmx-63] ([VirtusLab-Open-Source#161](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/161)) ([a284d59](a284d59))
* typescripted client service and controllers ([eddd4b3](eddd4b3))
gabrielsclimaco pushed a commit to zrp/uqbar-strapi-plugin-comments that referenced this issue Dec 20, 2023
# [1.1.0](v1.0.2...v1.1.0) (2023-10-04)

### Bug Fixes

* add types to Avatar component ([f12ea9c](f12ea9c))
* author blocked props ([d9d0777](d9d0777))
* author population ([VirtusLab-Open-Source#177](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/177)) ([5ba0d85](5ba0d85))
* change error 403 test ([99ec162](99ec162))
* custom field on existing entity ([VirtusLab-Open-Source#178](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/178)) ([5e6cc63](5e6cc63))
* fixed UserAvatar typing ([dd179c7](dd179c7))
* fixes after merge ([3b9eee2](3b9eee2))
* issue [VirtusLab-Open-Source#199](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/199) - undeclared codemirror dependency causes build crash ([ccc1f98](ccc1f98))
* issue [VirtusLab-Open-Source#201](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/201) fix the filtering by thread ([bdc292a](bdc292a))
* issue [VirtusLab-Open-Source#220](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/220), issue [VirtusLab-Open-Source#221](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/221) ([VirtusLab-Open-Source#222](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/222)) ([03d504a](03d504a))
* load only existing translations ([e0cea8d](e0cea8d))
* package.json outdated ([1ef26e5](1ef26e5))
* peer dependency ([50bd59c](50bd59c))
* stick to older match-sorter dependency following strapi ([70dd408](70dd408))
* strapi 4.13 packages alignment ([VirtusLab-Open-Source#229](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/229)) ([3432cd2](3432cd2))
* strapi v4.7.1 compatibility fix because of dependencies ([563f86c](563f86c))
* unused import removed ([ac7d47f](ac7d47f))

### Features

* **api:** issue [VirtusLab-Open-Source#209](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/209) - find all by author ([e47684a](e47684a))
* author entity props blocking ([VirtusLab-Open-Source#186](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/186)) ([6134f1e](6134f1e))
* basic filters options added to Discover and Reports ([074d23a](074d23a))
* comments custom field [CU-2tn2923] ([VirtusLab-Open-Source#157](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/157)) ([aaac8a0](aaac8a0)), closes [VirtusLab-Open-Source#158](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/158)
* create reports page [CU-20rfmkv] ([VirtusLab-Open-Source#153](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/153)) ([15b9b57](15b9b57))
* custom fields on server-side [CU-xhcmx-63] ([VirtusLab-Open-Source#161](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/161)) ([a284d59](a284d59))
* typescripted client service and controllers ([eddd4b3](eddd4b3))
gabrielsclimaco pushed a commit to zrp/uqbar-strapi-plugin-comments that referenced this issue Dec 20, 2023
* add types to Avatar component ([f12ea9c](f12ea9c))
* author blocked props ([d9d0777](d9d0777))
* author population ([VirtusLab-Open-Source#177](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/177)) ([5ba0d85](5ba0d85))
* change error 403 test ([99ec162](99ec162))
* custom field on existing entity ([VirtusLab-Open-Source#178](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/178)) ([5e6cc63](5e6cc63))
* fixed UserAvatar typing ([dd179c7](dd179c7))
* fixes after merge ([3b9eee2](3b9eee2))
* issue [VirtusLab-Open-Source#199](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/199) - undeclared codemirror dependency causes build crash ([ccc1f98](ccc1f98))
* issue [VirtusLab-Open-Source#201](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/201) fix the filtering by thread ([bdc292a](bdc292a))
* issue [VirtusLab-Open-Source#220](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/220), issue [VirtusLab-Open-Source#221](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/221) ([VirtusLab-Open-Source#222](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/222)) ([03d504a](03d504a))
* load only existing translations ([e0cea8d](e0cea8d))
* package.json outdated ([1ef26e5](1ef26e5))
* peer dependency ([50bd59c](50bd59c))
* stick to older match-sorter dependency following strapi ([70dd408](70dd408))
* strapi 4.13 packages alignment ([VirtusLab-Open-Source#229](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/229)) ([3432cd2](3432cd2))
* strapi v4.7.1 compatibility fix because of dependencies ([563f86c](563f86c))
* unused import removed ([ac7d47f](ac7d47f))

* **api:** issue [VirtusLab-Open-Source#209](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/209) - find all by author ([e47684a](e47684a))
* author entity props blocking ([VirtusLab-Open-Source#186](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/186)) ([6134f1e](6134f1e))
* basic filters options added to Discover and Reports ([074d23a](074d23a))
* comments custom field [CU-2tn2923] ([VirtusLab-Open-Source#157](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/157)) ([aaac8a0](aaac8a0)), closes [VirtusLab-Open-Source#158](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/158)
* create reports page [CU-20rfmkv] ([VirtusLab-Open-Source#153](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/153)) ([15b9b57](15b9b57))
* custom fields on server-side [CU-xhcmx-63] ([VirtusLab-Open-Source#161](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/161)) ([a284d59](a284d59))
* typescripted client service and controllers ([eddd4b3](eddd4b3))
gabrielsclimaco pushed a commit to zrp/uqbar-strapi-plugin-comments that referenced this issue Dec 20, 2023
* add types to Avatar component ([f12ea9c](f12ea9c))
* author blocked props ([d9d0777](d9d0777))
* author population ([VirtusLab-Open-Source#177](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/177)) ([5ba0d85](5ba0d85))
* change error 403 test ([99ec162](99ec162))
* custom field on existing entity ([VirtusLab-Open-Source#178](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/178)) ([5e6cc63](5e6cc63))
* fixed UserAvatar typing ([dd179c7](dd179c7))
* fixes after merge ([3b9eee2](3b9eee2))
* issue [VirtusLab-Open-Source#199](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/199) - undeclared codemirror dependency causes build crash ([ccc1f98](ccc1f98))
* issue [VirtusLab-Open-Source#201](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/201) fix the filtering by thread ([bdc292a](bdc292a))
* issue [VirtusLab-Open-Source#220](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/220), issue [VirtusLab-Open-Source#221](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/221) ([VirtusLab-Open-Source#222](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/222)) ([03d504a](03d504a))
* load only existing translations ([e0cea8d](e0cea8d))
* package.json outdated ([1ef26e5](1ef26e5))
* peer dependency ([50bd59c](50bd59c))
* stick to older match-sorter dependency following strapi ([70dd408](70dd408))
* strapi 4.13 packages alignment ([VirtusLab-Open-Source#229](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/229)) ([3432cd2](3432cd2))
* strapi v4.7.1 compatibility fix because of dependencies ([563f86c](563f86c))
* unused import removed ([ac7d47f](ac7d47f))

* **api:** issue [VirtusLab-Open-Source#209](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/209) - find all by author ([e47684a](e47684a))
* author entity props blocking ([VirtusLab-Open-Source#186](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/186)) ([6134f1e](6134f1e))
* basic filters options added to Discover and Reports ([074d23a](074d23a))
* comments custom field [CU-2tn2923] ([VirtusLab-Open-Source#157](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/157)) ([aaac8a0](aaac8a0)), closes [VirtusLab-Open-Source#158](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/158)
* create reports page [CU-20rfmkv] ([VirtusLab-Open-Source#153](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/153)) ([15b9b57](15b9b57))
* custom fields on server-side [CU-xhcmx-63] ([VirtusLab-Open-Source#161](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/161)) ([a284d59](a284d59))
* typescripted client service and controllers ([eddd4b3](eddd4b3))
github-actions bot pushed a commit to zrp/uqbar-strapi-plugin-comments that referenced this issue Dec 20, 2023
# [1.1.0](v1.0.2...v1.1.0) (2023-12-20)

### Bug Fixes

* add types to Avatar component ([f12ea9c](f12ea9c))
* author blocked props ([d9d0777](d9d0777))
* author population ([VirtusLab-Open-Source#177](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/177)) ([5ba0d85](5ba0d85))
* change error 403 test ([99ec162](99ec162))
* custom field on existing entity ([VirtusLab-Open-Source#178](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/178)) ([5e6cc63](5e6cc63))
* fixed UserAvatar typing ([dd179c7](dd179c7))
* fixes after merge ([3b9eee2](3b9eee2))
* issue [VirtusLab-Open-Source#199](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/199) - undeclared codemirror dependency causes build crash ([ccc1f98](ccc1f98))
* issue [VirtusLab-Open-Source#201](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/201) fix the filtering by thread ([bdc292a](bdc292a))
* issue [VirtusLab-Open-Source#220](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/220), issue [VirtusLab-Open-Source#221](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/221) ([VirtusLab-Open-Source#222](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/222)) ([03d504a](03d504a))
* load only existing translations ([e0cea8d](e0cea8d))
* package.json outdated ([1ef26e5](1ef26e5))
* peer dependency ([50bd59c](50bd59c))
* stick to older match-sorter dependency following strapi ([70dd408](70dd408))
* strapi 4.13 packages alignment ([VirtusLab-Open-Source#229](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/229)) ([3432cd2](3432cd2))
* strapi v4.7.1 compatibility fix because of dependencies ([563f86c](563f86c))
* unused import removed ([ac7d47f](ac7d47f))

### Features

* **api:** issue [VirtusLab-Open-Source#209](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/209) - find all by author ([e47684a](e47684a))
* author entity props blocking ([VirtusLab-Open-Source#186](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/186)) ([6134f1e](6134f1e))
* basic filters options added to Discover and Reports ([074d23a](074d23a))
* comments custom field [CU-2tn2923] ([VirtusLab-Open-Source#157](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/157)) ([aaac8a0](aaac8a0)), closes [VirtusLab-Open-Source#158](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/158)
* create reports page [CU-20rfmkv] ([VirtusLab-Open-Source#153](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/153)) ([15b9b57](15b9b57))
* custom fields on server-side [CU-xhcmx-63] ([VirtusLab-Open-Source#161](https://github.com/zrp/uqbar-strapi-plugin-comments/issues/161)) ([a284d59](a284d59))
* typescripted client service and controllers ([eddd4b3](eddd4b3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working moderation panel solved Issue has been solved v4 Strapi v4
Projects
None yet
Development

No branches or pull requests

2 participants