Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CU-2cwzjyr] Conflicting peer dependencies #136

Closed
kwiat1990 opened this issue Apr 24, 2022 · 8 comments
Closed

[CU-2cwzjyr] Conflicting peer dependencies #136

kwiat1990 opened this issue Apr 24, 2022 · 8 comments
Assignees
Labels
bug Something isn't working graphql GraphQL API issue v4 Strapi v4 wontfix This will not be worked on

Comments

@kwiat1990
Copy link
Contributor

kwiat1990 commented Apr 24, 2022

I got this error installing new version of the plugin:

ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/graphql
npm WARN   graphql@"^15.5.1" from @strapi/[email protected]
npm WARN   node_modules/@strapi/plugin-graphql
npm WARN     @strapi/plugin-graphql@"^4.1.8" from [email protected]
npm WARN     node_modules/strapi-plugin-comments
npm WARN   19 more (@apollo/federation, @graphql-tools/schema, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer graphql@"^0.5.0 || ^0.6.0 || ^0.7.0 || ^0.8.0-b || ^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0" from [email protected]
npm WARN node_modules/graphql-iso-date
npm WARN   graphql-iso-date@"^3.6.1" from @strapi/[email protected]
npm WARN   node_modules/@strapi/plugin-graphql
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/graphql
npm WARN   peer graphql@"^0.5.0 || ^0.6.0 || ^0.7.0 || ^0.8.0-b || ^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0" from [email protected]
npm WARN   node_modules/graphql-iso-date
npm WARN     graphql-iso-date@"^3.6.1" from @strapi/[email protected]
npm WARN     node_modules/@strapi/plugin-graphql
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/graphql
npm WARN   graphql@"^15.5.1" from @strapi/[email protected]
npm WARN   node_modules/@strapi/plugin-graphql
npm WARN     @strapi/plugin-graphql@"^4.1.8" from [email protected]
npm WARN     node_modules/strapi-plugin-comments
npm WARN   19 more (@apollo/federation, @graphql-tools/schema, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer graphql@"^0.9.1 || ^0.10.0 || ^0.12.0 || ^0.13.0" from [email protected]
npm WARN node_modules/graphql-type-long
npm WARN   graphql-type-long@"^0.1.1" from @strapi/[email protected]
npm WARN   node_modules/@strapi/plugin-graphql
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/graphql
npm WARN   peer graphql@"^0.9.1 || ^0.10.0 || ^0.12.0 || ^0.13.0" from [email protected]
npm WARN   node_modules/graphql-type-long
npm WARN     graphql-type-long@"^0.1.1" from @strapi/[email protected]
npm WARN     node_modules/@strapi/plugin-graphql

removed 31 packages, changed 8 packages, and audited 1650 packages in 15s

143 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

I have removed node_modules and package.lock.json but the errors persists.

@cyp3rius
Copy link
Collaborator

@kwiat1990 Which plugin version? Can you share package json depts?

@kwiat1990
Copy link
Contributor Author

kwiat1990 commented Apr 24, 2022

The error occurs using the newest version 2.1.0 as well as with the 2.0.10.

My dependencies are following:

"dependencies": {
    "@strapi/plugin-i18n": "^4.1.8",
    "@strapi/plugin-users-permissions": "^4.1.8",
    "@strapi/strapi": "^4.1.8",
    "pg": "^8.7.3",
    "strapi-plugin-comments": "^2.1.0",
    "strapi-plugin-placeholder": "^4.1.7",
    "strapi-plugin-slugify": "^2.2.1",
    "strapi-plugin-transformer": "^2.0.0"
  },

Strapi version seems to not have any impact on this behaviour. I've tested also 4.1.7.

@cyp3rius
Copy link
Collaborator

Will check that, we have got gql as dev dependency so it does not have any effect also. The only dependency is with Strapi GQL plugin.

A strange thing, anyway will check.

@cyp3rius
Copy link
Collaborator

cyp3rius commented Apr 25, 2022

@kwiat1990 I've published new version with some moves to peerDependencies. It's not causing the issue you described with all the plugins installed.

Version: 2.1.3

@cyp3rius cyp3rius self-assigned this Apr 25, 2022
@cyp3rius cyp3rius added bug Something isn't working waiting for feedback Waiting for reported feedback in progress v4 Strapi v4 graphql GraphQL API issue labels Apr 25, 2022
@cyp3rius cyp3rius changed the title Conflicting peer dependencies [CU-2cwzjyr] Conflicting peer dependencies Apr 25, 2022
@kwiat1990
Copy link
Contributor Author

Great! I will check the new version this afternoon and I hope I’ll get the same results.

@cyp3rius
Copy link
Collaborator

cyp3rius commented Apr 25, 2022

if it will not work still, add "@strapi/plugin-graphql": "^4.1.7" or higher for your dependencies as that's the plugin requirement.

Use version 2.1.4 of the plugin.

@kwiat1990
Copy link
Contributor Author

The problem still occurs with the latest version and even with the addition of @strapi/plugin-graphql (4.1.8). npm install produces following output:

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/graphql
npm WARN   graphql@"^15.5.1" from @strapi/[email protected]
npm WARN   node_modules/@strapi/plugin-graphql
npm WARN     @strapi/plugin-graphql@"^4.1.8" from the root project
npm WARN     1 more (strapi-plugin-comments)
npm WARN   19 more (@apollo/federation, @graphql-tools/schema, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer graphql@"^0.5.0 || ^0.6.0 || ^0.7.0 || ^0.8.0-b || ^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0" from [email protected]
npm WARN node_modules/graphql-iso-date
npm WARN   graphql-iso-date@"^3.6.1" from @strapi/[email protected]
npm WARN   node_modules/@strapi/plugin-graphql
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/graphql
npm WARN   peer graphql@"^0.5.0 || ^0.6.0 || ^0.7.0 || ^0.8.0-b || ^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0" from [email protected]
npm WARN   node_modules/graphql-iso-date
npm WARN     graphql-iso-date@"^3.6.1" from @strapi/[email protected]
npm WARN     node_modules/@strapi/plugin-graphql
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/graphql
npm WARN   graphql@"^15.5.1" from @strapi/[email protected]
npm WARN   node_modules/@strapi/plugin-graphql
npm WARN     @strapi/plugin-graphql@"^4.1.8" from the root project
npm WARN     1 more (strapi-plugin-comments)
npm WARN   19 more (@apollo/federation, @graphql-tools/schema, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer graphql@"^0.9.1 || ^0.10.0 || ^0.12.0 || ^0.13.0" from [email protected]
npm WARN node_modules/graphql-type-long
npm WARN   graphql-type-long@"^0.1.1" from @strapi/[email protected]
npm WARN   node_modules/@strapi/plugin-graphql
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/graphql
npm WARN   peer graphql@"^0.9.1 || ^0.10.0 || ^0.12.0 || ^0.13.0" from [email protected]
npm WARN   node_modules/graphql-type-long
npm WARN     graphql-type-long@"^0.1.1" from @strapi/[email protected]
npm WARN     node_modules/@strapi/plugin-graphql

As long as everything works just fine it doesn't bother me a lot, so we could close this thread. Unless you would like to invest some more time in the bug fixing?

@cyp3rius
Copy link
Collaborator

cyp3rius commented May 4, 2022

Not critical ones and we're using Strapi plugins as dependencies so I would close it :)

@cyp3rius cyp3rius closed this as completed May 4, 2022
@cyp3rius cyp3rius added wontfix This will not be worked on and removed waiting for feedback Waiting for reported feedback in progress labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working graphql GraphQL API issue v4 Strapi v4 wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants