Fix issue of overspecialisation of outputs Dict of variables requested by the user #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can get specialised to eg Dict{String => Tuple{Symbol, Symbol} }} if the # of output variables is the same for all scales. This causes problems when we add :node to the Tuples. Instead, convert the dict's tuples to vectors while we're editing it, and then convert it back to a tuple once the mutation period is done. All tests pass
Samuel-amap
commented
Oct 25, 2024
VEZY
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a known but marginal issue in pre_allocate_outputs, which had workarounds on the user side.