Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert nav social links to individual list items to improve accessibility #1293

Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix: convert nav social links to individual list items to improve accessibility #1293

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d62414f
fix: convert nav social links to individual list items to improve acc…
Insider32 Nov 18, 2024
d13e056
Remove unneeded `d-flex` class
meg-gutshall Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/components/Nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ export default function Nav() {
</li>
</ul>

<ul className="navbar-nav">
<li className="nav-item d-flex justify-content-end">
<ul className="navbar-nav flex-row justify-content-end">
<li className="nav-item">
<a
href="https://github.com/Virtual-Coffee"
aria-label="GitHub"
Expand All @@ -97,6 +97,8 @@ export default function Nav() {
<path d="M12 .297c-6.63 0-12 5.373-12 12 0 5.303 3.438 9.8 8.205 11.385.6.113.82-.258.82-.577 0-.285-.01-1.04-.015-2.04-3.338.724-4.042-1.61-4.042-1.61C4.422 18.07 3.633 17.7 3.633 17.7c-1.087-.744.084-.729.084-.729 1.205.084 1.838 1.236 1.838 1.236 1.07 1.835 2.809 1.305 3.495.998.108-.776.417-1.305.76-1.605-2.665-.3-5.466-1.332-5.466-5.93 0-1.31.465-2.38 1.235-3.22-.135-.303-.54-1.523.105-3.176 0 0 1.005-.322 3.3 1.23.96-.267 1.98-.399 3-.405 1.02.006 2.04.138 3 .405 2.28-1.552 3.285-1.23 3.285-1.23.645 1.653.24 2.873.12 3.176.765.84 1.23 1.91 1.23 3.22 0 4.61-2.805 5.625-5.475 5.92.42.36.81 1.096.81 2.22 0 1.606-.015 2.896-.015 3.286 0 .315.21.69.825.57C20.565 22.092 24 17.592 24 12.297c0-6.627-5.373-12-12-12" />
</svg>
</a>
</li>
<li className="nav-item">
<a
href="https://twitter.com/VirtualCoffeeIO"
aria-label="Twitter"
Expand All @@ -113,6 +115,8 @@ export default function Nav() {
<path d="M389.2 48h70.6L305.6 224.2 487 464H345L233.7 318.6 106.5 464H35.8L200.7 275.5 26.8 48H172.4L272.9 180.9 389.2 48zM364.4 421.8h39.1L151.1 88h-42L364.4 421.8z" />
</svg>
</a>
</li>
<li className="nav-item">
<a
href="https://youtube.com/c/virtualcoffeeio"
aria-label="YouTube"
Expand Down
Loading