Remove indent_size from editorconfig
#1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the style is a tab, the files should be indented according to the users preference
👷 Deploy Preview for virtual-coffee-io processing.
|
mikestreety
changed the title
indent_size from editorconfig
danieltott
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit of a punt and something I noticed when doing #1040
Description
The
.editorconfigfile specifies tabs (yay!) as theindent_style, however it was strict on theindent_size- which isn't required if using tabs.It also adds the final new line to the
.editorconfigfile, as required in the.editorconfigfileMethodology
I'm a massive tab fanboy, but love a good sized indent of 4 and have this set in my IDE. I was surprised, when opening VirtualCoffee that, despite everything using tabs, it was extremely tight.
After searching my IDE, i realised the
.editorconfigspecifiedindent_size = 2which, considering it is a tab character, should not be needed.Removing this allows the tab size to be set in an IDE level for user preference while still keeping the tab convention.
Side note: I appreciate this MR is being raised without an issue and is 95% personal preference. If there is a reason I've not thought of for 2 space tabs to be force, I completely understand! 😄
Code of Conduct