Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VP-3582: Add outlines property to product for promotion evaluation #484

Merged
merged 8 commits into from
Jul 29, 2020

Conversation

ilyawzrd
Copy link
Contributor

@ilyawzrd ilyawzrd commented Jul 28, 2020

Problem

Marketing promotions don’t work as expected, because the wrong one outline for product is chosen.

Solution

In DynamicExpressionsModule we have support for multiple outlines, so just need to pass string that contains multiple outlines with separator

Proposed of changes

Add new Product propetry - Outlines, that contains all outlines of product with separator and then pass it to ProductPromoEntry

Make sure these boxes are checked:

@ilyawzrd ilyawzrd requested review from tatarincev and yecli July 28, 2020 15:10
yecli
yecli previously approved these changes Jul 28, 2020
@yecli yecli merged commit 4504532 into support/2.x-dev Jul 29, 2020
@yecli yecli deleted the bug/VP-3582 branch July 29, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants