Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VP-2322: Show exception in SendNotificationAsync for future debug #437

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

ilyawzrd
Copy link
Contributor

@ilyawzrd ilyawzrd commented Jun 9, 2020

No description provided.

@ilyawzrd ilyawzrd requested a review from tatarincev June 9, 2020 11:54
@vc-ci
Copy link
Contributor

vc-ci commented Jun 9, 2020

SonarQube analysis reported 2 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR AccountController.cs#L295: Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed. rule
  2. INFO AccountController.cs#L478: Complete the task associated to this 'TODO' comment. rule

Copy link
Contributor

@t13ka t13ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. We have to show/log actual errors to understand the problems with called code

@t13ka t13ka merged commit c6a2e33 into dev Jun 10, 2020
@t13ka t13ka deleted the fix/VP-2322 branch June 10, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants