Add products to line items on cart refresh #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tatarincev
reviewed
Dec 19, 2017
| @@ -82,12 +82,15 @@ public void LoadOrCreateNewTransientCart(string cartName, Store store, User user | |||
| //Load cart payment plan with have same id | |||
| if (store.SubscriptionEnabled) | |||
| { | |||
| var productsIds = cart.Items.Select(x => x.ProductId).Distinct().ToArray(); | |||
| var products = await _catalogService.GetProductsAsync(productsIds, ItemResponseGroup.ItemWithPrices); | |||
There was a problem hiding this comment.
Need to load products with these response groups
ItemResponseGroup.ItemWithPrices | ItemResponseGroup.ItemWithDiscounts | ItemResponseGroup.Inventory
|
|
|
"The product for LineItem added to the cart was removed" On this case we have message that product is unavailable
|
tatarincev
approved these changes
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.