#VP-2081 add member id to identity result #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akak1977
approved these changes
May 20, 2020
tatarincev
requested changes
May 20, 2020
|
|
||
| namespace VirtoCommerce.Storefront.Model.Security | ||
| { | ||
| public class MemberIdIdentityResult : IdentityResult |
There was a problem hiding this comment.
I suggest defining a new type of UserActionIdentityResult instead of deriving from IdentityResult that will contain all properties from IdentityResult to preserving backward compatibility plus in addition with the new User property.
vc-ci
reviewed
May 22, 2020
| @@ -181,9 +191,9 @@ public async Task<ActionResult<IdentityResult>> RegisterUser([FromBody] Organiza | |||
| [HttpPost("invitation")] | |||
| [ValidateAntiForgeryToken] | |||
| [ProducesResponseType(401)] | |||
| public async Task<ActionResult<IdentityResult>> CreateUserInvitation([FromBody] UsersInvitation invitation) | |||
| public async Task<ActionResult<UserActionIdentityResult>> CreateUserInvitation([FromBody] UsersInvitation invitation) | |||
There was a problem hiding this comment.
vc-ci
reviewed
May 22, 2020
| @@ -77,10 +77,10 @@ public async Task<ActionResult<User>> GetUserById(string userId) | |||
| [HttpDelete("{userId}")] | |||
| [Authorize(SecurityConstants.Permissions.CanDeleteUsers)] | |||
| [ValidateAntiForgeryToken] | |||
| public async Task<ActionResult<IdentityResult>> DeleteUser([FromRoute] string userId) | |||
| public async Task<ActionResult<UserActionIdentityResult>> DeleteUser([FromRoute] string userId) | |||
| { | |||
| //TODO: Authorization check | |||
There was a problem hiding this comment.
vc-ci
reviewed
May 22, 2020
| @@ -311,10 +321,10 @@ public async Task<ActionResult<UserSearchResult>> SearchOrganizationUsersAsync([ | |||
| [HttpPost("{userId}/lock")] | |||
| [Authorize(SecurityConstants.Permissions.CanEditUsers)] | |||
| [ValidateAntiForgeryToken] | |||
| public async Task<ActionResult<IdentityResult>> LockUser([FromRoute]string userId) | |||
| public async Task<ActionResult<UserActionIdentityResult>> LockUser([FromRoute]string userId) | |||
| { | |||
| //TODO: Add authorization checks | |||
There was a problem hiding this comment.
vc-ci
reviewed
May 22, 2020
| @@ -334,10 +344,10 @@ public async Task<ActionResult<IdentityResult>> LockUser([FromRoute]string userI | |||
| [HttpPost("{userId}/unlock")] | |||
| [Authorize(SecurityConstants.Permissions.CanEditUsers)] | |||
| [ValidateAntiForgeryToken] | |||
| public async Task<ActionResult<IdentityResult>> UnlockUser([FromRoute] string userId) | |||
| public async Task<ActionResult<UserActionIdentityResult>> UnlockUser([FromRoute] string userId) | |||
| { | |||
| //TODO: Add authorization checks | |||
There was a problem hiding this comment.
akak1977
previously approved these changes
May 25, 2020
|
When this pull request is going to be released? |
akak1977
previously approved these changes
May 29, 2020
tatarincev
previously approved these changes
Jun 3, 2020
akak1977
force-pushed
the
feature/3.0.0/VP-2081-add-member-id-to-identity-result
branch
from
9d9b070 to
89914be
Compare
akak1977
deleted the
feature/3.0.0/VP-2081-add-member-id-to-identity-result
branch
|
SonarQube analysis reported 8 issues
Watch the comments in this conversation to review them. 4 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.