Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#VP-1982 invisible variation properties if is not active #410

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

kostyrin
Copy link
Contributor

No description provided.

@vc-ci
Copy link
Contributor

vc-ci commented Apr 27, 2020

SonarQube analysis reported 3 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL CatalogConverter.cs#L309: Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. rule
  2. MAJOR CatalogConverter.cs#L116: Change this condition so that it does not always evaluate to 'false'; some subsequent code is never executed. rule
  3. MAJOR CatalogConverter.cs#L118: Merge this if statement with the enclosing one. rule

@akak1977 akak1977 merged commit 4a26c67 into dev Apr 29, 2020
@akak1977 akak1977 deleted the bug/3.0.0/VP-1982-invisible-variation-is-not-active branch April 29, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants