Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vp 1266 incorect tax with ava tax #370

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

AliveMen
Copy link
Contributor

add taxType to convertors

@AliveMen AliveMen requested a review from yecli January 22, 2020 07:13
@vc-ci
Copy link
Contributor

vc-ci commented Jan 22, 2020

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. INFO CartConverter.cs#L803: Complete the task associated to this 'TODO' comment. rule

@yecli yecli requested a review from tatarincev January 22, 2020 07:20
@yecli yecli merged commit fb62d07 into dev Jan 22, 2020
@yecli yecli deleted the fix_vp-1266_incorect_tax_with_AvaTax branch January 22, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants