Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserGroups, CurrentPricelists should be part of cacheKey in SearchProductsAsync #266

Closed
OlegoO opened this issue Jun 3, 2019 · 2 comments
Closed

UserGroups, CurrentPricelists should be part of cacheKey in SearchProductsAsync #266

OlegoO opened this issue Jun 3, 2019 · 2 comments
Assignees
@yecli
Labels
bug client request

Comments

@OlegoO
Copy link
Contributor

OlegoO commented Jun 3, 2019

Version info:

  • Storefront version: v3.2.9

Expected behaviour

Display different product list for the different customer if they have different either UserGroups or CurrentPricelists

Actual behaviour

The customer sees the wrong product list from the caches.

Steps to reproduce

  1. Create customer A and customer B with different either UserGroups or CurrentPricelists. Customize the catalogue to see a different set of the products on either UserGroups or CurrentPricelists.
  2. Log in with customer A and open category page, see one set of the products
  3. Log in with customer B and open category page, see the same (wrong) set of the products

https://github.com/VirtoCommerce/vc-storefront-core/blob/master/VirtoCommerce.Storefront/Domain/Catalog/CatalogService.cs#L204

https://github.com/VirtoCommerce/vc-storefront-core/blob/master/VirtoCommerce.Storefront/Domain/Catalog/CatalogConverter.cs#L161

https://github.com/VirtoCommerce/vc-storefront-core/blob/master/VirtoCommerce.Storefront/Domain/Catalog/CatalogConverter.cs#L163

Note: I think we should remove workContext from Converters or be careful with cacheKey

Note: Same problem can occur for other cacheKey. Need to review
@OlegoO
Copy link
Contributor Author

OlegoO commented Jun 3, 2019

I see that @tatarincev fixed DEV for UserGroups
6d83b4e

but not for PriceLists

@yecli yecli added this to the Operations milestone Jun 5, 2019
yecli added a commit that referenced this issue Jun 5, 2019
@yecli
#266: Moved Product properties out of cached Product for search, as i…
0c12b4c 
…t was done for getting by ids. Thus we make properties caching distributed, and e.g. Prices would be updated when needed, as they are loaded independently.
yecli added a commit that referenced this issue Jun 6, 2019
@yecli
#266: Renamed LoadProductProperties to LoadProductDependencies.
8642880
yecli added a commit that referenced this issue Jun 6, 2019
@yecli
#266 UserGroups, CurrentPricelists should be part of cacheKey in Sear…
51a6be4 
…chProductsAsync (#269)

Moved Product properties out of cached Product for search, as it was done for getting by ids. Thus we make properties caching distributed, and e.g. Prices would be updated when needed, as they are loaded independently.
@yecli
Copy link
Contributor

yecli commented Jun 6, 2019

https://github.com/VirtoCommerce/vc-storefront-core/releases/tag/v3.2.11

@yecli yecli closed this as completed Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yecli yecli

Labels
bug client request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OlegoO @yecli