Fix potential bug with irrational memory usage leads to memory exhausted

VirtoCommerce · Jun 5, 2019 · 13d1ff3 · 13d1ff3
1 parent 4151c60
commit 13d1ff3
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/VirtoCommerce.Storefront/Caching/StorefrontMemoryCache.cs b/VirtoCommerce.Storefront/Caching/StorefrontMemoryCache.cs
@@ -47,7 +47,7 @@ public bool TryGetValue(object key, out object value)
             return _memoryCache.TryGetValue(key, out value);
         }
 
-        protected TimeSpan AbsoluteExpiration => _storefrontOptions.CacheAbsoluteExpiration;
+        protected TimeSpan? AbsoluteExpiration => _storefrontOptions.CacheAbsoluteExpiration;
 
         protected bool CacheEnabled => _storefrontOptions.CacheEnabled;
 

diff --git a/VirtoCommerce.Storefront/Infrastructure/StorefrontOptions.cs b/VirtoCommerce.Storefront/Infrastructure/StorefrontOptions.cs
@@ -15,7 +15,7 @@ public class StorefrontOptions
 
         public bool CacheEnabled { get; set; }
 
-        public TimeSpan CacheAbsoluteExpiration { get; set; }
+        public TimeSpan? CacheAbsoluteExpiration { get; set; }
 
         public int PageSizeMaxValue { get; set; } = 100;
 

diff --git a/VirtoCommerce.Storefront/appsettings.json b/VirtoCommerce.Storefront/appsettings.json
@@ -5,7 +5,6 @@
   "VirtoCommerce": {
     "DefaultStore": "Electronics",
     "CacheEnabled": "true",
-    "CacheAbsoluteExpiration": "10:00:00",
     "PageSizeMaxValue": 100,
     "Endpoint": {
       "Url": "http://localhost/admin",