feat: text section for configurable products #1581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-kalachikov
requested review from
Andrew-Orlov,
goldenmaya,
NaMax66 and
IrinaSer
and removed request for
a team
|
NaMax66
approved these changes
Feb 13, 2025
goldenmaya
requested changes
Feb 14, 2025
| </script> | ||
|
|
||
| <style lang="scss"> | ||
| .configuration-option-product { |
There was a problem hiding this comment.
Bad idea to mutate product-card like this, it means ui-kit design does not cover your case. Try to use props only without any weird mutations.
There was a problem hiding this comment.
BEM block === file name
There was a problem hiding this comment.
BEM block === file name
There was a problem hiding this comment.
- BEM block === file name
- Weird naming for component (not text only, you also have radio buttons and input here)
| @apply flex flex-col gap-3; | ||
|
|
||
| &__field { | ||
| @apply flex gap-3 p-4 items-center odd:bg-[--bg]; |
There was a problem hiding this comment.
do we realy need --bg variable?
| /> | ||
| <VcProductImage /> | ||
| </template> |
There was a problem hiding this comment.
add empty line to separate tags - check other places as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screencast.from.2025-02-13.08-17-39.mp4
References
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-2616
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.16.0-pr-1581-c739-c7390df2.zip