Skip to content

Commit

Permalink
tests, hotplug: Remove redundant migration
Browse files Browse the repository at this point in the history
When testing multiple hotplug interfaces a redundant migration was
executed after the second hotplug.

By executing the migration before the new interface propagated to the
VMI, flakes are seen (pod interface missing on the target).

Therefore, drop one migration and depend on the one performed as part of
the `verifyDynamicInterfaceChange` helper.

Signed-off-by: Edward Haas <[email protected]>
  • Loading branch information
EdDev authored and VirrageS committed Nov 17, 2023
1 parent 8048a51 commit ecef7d6
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions tests/network/hotplug.go
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,6 @@ var _ = SIGDescribe("nic-hotplug", func() {
),
).To(Succeed())

if plugMethod == migrationBased {
migrate(hotPluggedVMI)
}

By("wait for the second network to appear in the VMI spec")
EventuallyWithOffset(1, func() []v1.Network {
var err error
Expand Down

0 comments on commit ecef7d6

Please sign in to comment.