Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #394 #429

Open
wants to merge 76 commits into
base: develop/1.11.0
Choose a base branch
from

Conversation

meiMingle
Copy link

No description provided.

jaskarth and others added 30 commits April 4, 2024 15:08
…a 21 (Vineflower#355)

* Fix switches with enums for enums in other classes and null cases

* Remove println
* Fix if statements inside switch statements preventing switch expressions

* Update test output

* Fix switch statements that throw an exception not being converted

* Add comment
…o arguments (Vineflower#362)

* Fix formatter emitting blank lines for long method invocations with no arguments

fixes Vineflower#359

* Simplify test
…#361)

* Fix local class methods not getting the parent context

* Add test
…ineflower#366)

They may be needed later when writing other classes.

This fixes an issue where non-static inner class constructor invocations from foreign classes would inconsistently have the synthetic enclosing this instance removed from the parameter list, depending on the order they were processed in (and consequently having strange interactions with multithreaded writing)
* Don't write explicit casts where redundant

* Fix numeric parameter disambiguation

* Write casts when not doing so would change behavior

* Fix failing test

---------

Co-authored-by: Jasmine Karthikeyan <[email protected]>
…er#370)

* add option to exclude classes from decompilation

* add @type annotation

* rename into excluded-classes, remove short name
* Default arguments in function / constructor declarations

* Improve defaults detection and parsing, and add option for unknown defaults

* Fix ambiguous wording

* Clean up with J12-17 features

* Describe in detail what happens to default parameters

* Fix cases with 32 or more parameters

* Improve wording about default constructors

* Clean up imports

* Fix problems with long/double parameters
…kes up multiple lines before reformatting (like an anonymous class instantiation) (Vineflower#379)
* Simplify empty anonymous class bodies to `{}`

This is typically how people actually write code like this (as can be seen in the existing tests)

The improvement is extra noticeable with things like type tokens

* Switch to AtomicBoolean and add comments
…he number (Vineflower#395)

* Add failing test for number casts issue

* make sure to include casts for numeric operations
* Fix variable used in switch head not being inlined

* Update dec files

* Comments and put streams on multiple lines
* Fix intersection casts for direct methods

* Add support for variable assignments

* Use var for variables that represent intersection types and update tests

* Add comments and remove println

* Add support for when an intersection type is casted back to it's
original type
sschr15 and others added 23 commits August 18, 2024 18:41
* Add a programmatic way of getting all options, including plugin options

* Missed one Type call

* Fix case when `null` is in the defaults

* Add documentation on the option getters
* Allow plugins to change decompiled file extensions

* Address review comments
… method (Vineflower#423)

* Fix lambdas in anonymous classes referencing parameters from the root
method

* Update test
* chore(deps): Bump GHA versions

* chore(deps): Bump Gradle and plugin versions
@meiMingle meiMingle changed the base branch from master to develop/1.11.0 September 9, 2024 07:53
@jaskarth jaskarth added Subsystem: Writing Anything concerning how expressions are written Priority: Medium Medium priority bugfix Fixes a bug labels Sep 9, 2024
@jaskarth jaskarth force-pushed the develop/1.11.0 branch 2 times, most recently from a6698b7 to 0be304f Compare February 25, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug Priority: Medium Medium priority Subsystem: Writing Anything concerning how expressions are written
Projects
None yet
Development

Successfully merging this pull request may close these issues.